[Seaside-dev] WAComboResponse + Zinc

[Sven Van Caekenberghe]

Ken,

On 12 Jan 2013, at 01:07, Ken Treis <ken at miriamtech.com> wrote:

> Sven,
> 
> Let me know what you think of Zinc-Seaside-KenTreis.36.2.

I merged your changes in the main branch, now at Zinc-Seaside-SvenVanCaekenberghe.37

> On Jan 11, 2013, at 7:16 AM, Sven Van Caekenberghe wrote:
> 
>> As there is no #count (for streams) in my image (Pharo 2.0), #nextChunkPut: delegates better anyway.
> 
> I was running on a bleeding-edge Seaside-Core package, and I'm guessing you were running on a Metacello load of 3.1.0 which is a little older. Either way, this is internal to Seaside proper (like you said) and doesn't require any changes to the Zinc adaptor itself.

I just loaded Seaside-Core-KenTreis.784 from http://www.squeaksource.com/Seaside31 and my remark is still relevant.
Should I be looking elsewhere ?

>> Now, your version of the adaptor moves a lot of logic from the adaptor and Zinc itself to Seaside as WAComboResponse does actually write the response completely itself. For that reason I would prefer to move your 4 changes on ZnZincServerAdaptor to a new subclass, like ZnZincComboResponseServerAdaptor or something similar. That way both version can live next to each other and users can pick the one they want. Agreed ?
> 
> Sounds reasonable -- I called it ZnZincStreamingServerAdaptor, but feel free to rename as you see fit.

Good name.

> Thanks for helping to get me going in the right direction.

Thank _you_ !

Sven