[Seaside-dev] Pharo issue 13063

[Johan Brichau]

Hi Stephan,

I don't know if now is the time for it, but we might want to take the opportunity to improve the code of NEC on this.

I have the impression the check for the presence of WAHtmlCanvas|WARenderCanvas should actually occur in NECVarTypeGuesser>>getClassFromTypeSuggestingName:
Next, frameworks (like Seaside) would need a place to plugin such type-guessing improvements. For that we could add a dictionary to NECVarTypeGuesser where frameworks can register a 'varname->class' mapping. 

Afaik, a small change that is worthwhile for future code changes and a chance for frameworks to improve the code completion (I guess this is used for code completion? )

But, as I said, we can also take this to Pharo4 if necessary...

thanks for catching the bug ;-)
Johan

On 21 Mar 2014, at 20:54, Johan Brichau <johan at inceptive.be> wrote:

> Ok, your fix seems correct but... 
> 
> wtf? why is there an explicit check for WARenderCanvas necessary in the NEC package ?
> 
> That has nothing to do with your fix, of course.
> Unless there is a better way to specialize this implementation and include the code in the Pharo-Development package of Seaside?
> 
> Johan
> 
> On 21 Mar 2014, at 13:56, Stephan Eggermont <stephan at stack.nl> wrote:
> 
>> Johan wrote:
>>> Stupid question maybe, but how can we see the changes? 
>> 
>> Not so stupid, it is a platform specific fix in a somewhat seaside
>> related part.
>> 
>> The slice is in the Pharo30 inbox.
>> 
>> So, preferably:
>> - download a latest vm from ci
>> - download a latest 30  image (with seaside loaded, or load seaside in a plain image)
>> - open monticello
>> - open the pharo30 inbox repository
>> - type 13063 in the package filter
>> - select merge to see the change
>> - merge it, and try
>> 
>> Stephan _______________________________________________
>> seaside-dev mailing list
>> seaside-dev at lists.squeakfoundation.org
>> http://lists.squeakfoundation.org/mailman/listinfo/seaside-dev
>