[Seaside-dev] Twitter Bootstrap examples interfering with WAExampleBrowser

Philippe Marschall philippe.marschall at gmail.com
Tue Sep 16 09:26:03 UTC 2014


On Mon, Sep 15, 2014 at 8:05 PM, Johan Brichau <johan at inceptive.be> wrote:
>
> On 15 Sep 2014, at 19:37, Philippe Marschall <philippe.marschall at gmail.com> wrote:
>
>> On Sat, Sep 13, 2014 at 10:45 AM, Johan Brichau <johan at inceptive.be> wrote:
>>> hi Phil,
>>>
>>> Thanks for reporting the issue.
>>> Your fix literally filters out the TBS examples, which I want to improve on a little and rather rest for ‘Seaside only’ classes.
>>>
>>> I think only including the classes prefixed with WA might be a better solution but Philippe maybe has a better understanding of the history of the naming convention that was chosen for examples.
>>> Philippe?
>>
>> Gee, I don't know that class even existed. Is the conflict due to CSS
>> issues or that Twitter Bootstrap uses class side #example methods for
>> something completely different?
>
> Haha… ok, I guess we can safely select only those classes starting with WA in the WAExampleBrowser then :)

What role does WAExampleBrowser have that isn't already covered by the
functional tests? If it only contains the handful of examples in WA*
should we just remove it? If we want to make it generic should make it
more safe by introducing a selector like #containsSeasideExamples?

Cheers
Philippe


More information about the seaside-dev mailing list