[Seaside-dev] Configurable current request context variable

[Max Leske]

> On 16 May 2017, at 22:24, Esteban A. Maringolo <emaringolo at gmail.com> wrote:
> 
> 2017-05-16 17:20 GMT-03:00 Max Leske <maxleske at gmail.com>:
>> Hi Philippe,
>> 
>> I’ve created an implementation, trying to do what you suggest; these are the changes:
>> 
>> - removed WADynamicVariable
>> - added GRDynamicVariable to Grease-Core

Sorry, this should have been Grease-Pharo30-Core.

>> - subclasses of WADynamicVariable now inherit from GRDynamicVariable
>> - test cases for WADynamicVariable moved to Grease-Tests-Core (not sure about this. The tests should be the same for all platforms but Grease-Core does not contain GRDynamicVariable…)
> 
> Great! Thank you Max.
> 
> Is Grease-*Dialect*-Core (e.g. Grease-Pharo-Core) a prerequisite of Grease-Core?

No, the other way around, according to the configuration.

> 
> 
>> I don’t have write permissions on STHub, so I’m attaching the patches below.
> 
> As expected, the file didn't make it to the attachments of the mail :)

Especially because I forgot to attach them… :p

Here’s the link to a zip archive with the patch: https://www.dropbox.com/s/pgd6k12mwh92s06/GRDynamicVariable_patch.zip?dl=0 <https://www.dropbox.com/s/pgd6k12mwh92s06/GRDynamicVariable_patch.zip?dl=0>.

Cheers,
Max

> 
>> I can also make the change for Squeak but I’m not sure how I would go about committing the change for VW / VASt. Let me know what you think.
> 
> 
> 
> 
> Esteban A. Maringolo
> _______________________________________________
> seaside-dev mailing list
> seaside-dev at lists.squeakfoundation.org
> http://lists.squeakfoundation.org/mailman/listinfo/seaside-dev

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/seaside-dev/attachments/20170517/a06f3758/attachment.html>