<div class="gmail_quote">Why not? Isn't that a bug? (I'm only half joking :) )</div><div class="gmail_quote"><br></div><div class="gmail_quote">According to the ANSI spec, though, #allSubclasses need not necessarily return on OrderedCollection (in fact, why should it be ordered?). Maybe that's too theoretical an issue to worry about but if you're going to force a conversion of one of the collections, it's a bit odd not to ensure the type of the other one.</div>
<div class="gmail_quote"><br></div><div class="gmail_quote">If this is coming up now, why don't we at least define what kind of collection #potentialParents should return (I don't think it needs to be ordered?), write a unit test for it, and make sure it always returns that. It might be better to do "allSubclasses asSet"?</div>
<div class="gmail_quote"><br></div><div class="gmail_quote">Julian</div><div class="gmail_quote"><br></div><div class="gmail_quote">On Wed, Jun 17, 2009 at 2:17 PM, <span dir="ltr"><<a href="mailto:squeak-dev-noreply@lists.squeakfoundation.org">squeak-dev-noreply@lists.squeakfoundation.org</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">Michael Lucas-Smith uploaded a new version of Seaside-Tools-Web to project Seaside 2.9:<br>
<a href="http://www.squeaksource.com/Seaside29/Seaside-Tools-Web-mls.5.mcz" target="_blank">http://www.squeaksource.com/Seaside29/Seaside-Tools-Web-mls.5.mcz</a><br>
<br>
==================== Summary ====================<br>
<br>
Name: Seaside-Tools-Web-mls.5<br>
Author: mls<br>
Time: 17 June 2009, 2:16:56 pm<br>
UUID: 78a3eb34-4d01-4e6f-808d-c7a472ccf852<br>
Ancestors: Seaside-Tools-Web-jf.4<br>
<br>
- You can't concatenate an OrderedCollection with a Set in VW<br>
<br>
=============== Diff against Seaside-Tools-Web-jf.4 ===============<br>
<br>
Item was changed:<br>
----- Method: WAUserConfigurationEditor>>potentialParents (in category 'rendering-ancestry') -----<br>
potentialParents<br>
^ ((WASystemConfiguration allSubclasses collect: [ :each | each instance ]),<br>
+ WASharedConfiguration configurations asOrderedCollection)<br>
- WASharedConfiguration configurations)<br>
select: [ :each |<br>
(self configuration canAddParent: each)<br>
and: [ (self configuration inheritsFrom: each) not ] ]!<br>
<br>
<br>
_______________________________________________<br>
commits mailing list<br>
To unsubscribe, email <a href="mailto:commits-leave@lists.seaside.st">commits-leave@lists.seaside.st</a><br>
<a href="http://lists.seaside.st/listinfo/commits" target="_blank">http://lists.seaside.st/listinfo/commits</a><br>
</blockquote></div><br>