Thanks Lukas!<br><br>See my answers below!<br><br>Gerhard<br><br><div class="gmail_quote">On Tue, Sep 29, 2009 at 9:51 AM, Lukas Renggli <span dir="ltr"><<a href="mailto:renggli@gmail.com">renggli@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">I really like the new configuration interface. It seems to be much<br>
easier to navigate than the old one.<br>
<br>
There are a few technical issues I discovered:<br>
<br>
- WADispatcherCommand is in the WAPlugin hierarchy but it has a<br>
completely different naming convention than the rest of the classes. I<br>
suggest to stick with the existing naming conventions, e.g.<br>
WA${Action}DipatcherPlugin<br></blockquote><div><br> Ok, will be changed! <br><br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<br>
- There are several senders of #ifNotNil: with an argument. This is<br>
not portable.<br></blockquote><div><br> Ok, will be changed! <br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<br>
- Otherwise the code looks extremely clean and works very well.<br>
<br>
- The configuration interface of a particular application is no longer restful.<br></blockquote><div> </div><div> I know, If it is really necessary I could add it again!<br><br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<br>
- WADispatcherBrowser is using a different infrastructure. Maybe we<br>
want to merge that?<br></blockquote><div><br>I am not sure about that?<br> </div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<br>
For the design I also have some comments:<br>
<br>
- The navigation of the dispatcher tree is not really intuitive to me.<br>
When clicking on '+' something unexpected happens.<br></blockquote><div><br>Well, I don't like it too.<br>Maybe I should use a real tree instead of jumping between the dispatchers.<br>Any other suggestions?<br>
<br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<br>
- The help button is an excellent idea, but instead of toggling it on<br>
and off it would probably be more convenient just to have a tooltip or<br>
open the text in a separate popup window. If there is no help, the<br>
help buttons shouldn't be displayed at all.<br></blockquote><div><br>Ok, disabling the help buttons is easy.<br>Do you mean open a popup window with e.g. lightbox ?<br>And a tooltip should work with Ajax?<br>I dont want to create new dependencies.<br>
<br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<br>
- The buttons on the +/-/up/down are not really intuitive. I suggest<br>
that we use the same icon-set as we do for the halos.<br></blockquote><div> </div><div>Ok, I will change that too.<br><br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<br>
- In general the design feels a bit boxy (old) to me. If you don't<br>
mind I'll have a look at the CSS?<br></blockquote><div> </div><div>Of course I dont mind. The CSS is still not optimized anyway.<br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<br>
Lukas<br>
<font color="#888888"><br>
--<br>
Lukas Renggli<br>
<a href="http://www.lukas-renggli.ch" target="_blank">http://www.lukas-renggli.ch</a><br>
</font><div><div></div><div class="h5">_______________________________________________<br>
seaside-dev mailing list<br>
<a href="mailto:seaside-dev@lists.squeakfoundation.org">seaside-dev@lists.squeakfoundation.org</a><br>
<a href="http://lists.squeakfoundation.org/mailman/listinfo/seaside-dev" target="_blank">http://lists.squeakfoundation.org/mailman/listinfo/seaside-dev</a><br>
</div></div></blockquote></div><br>