The jQuery Ui homepage also hides the source by default.<br>I like this approach, because It doesn't show you to much information<br>at the same time, and I dont have to scroll up and down.<br><br>I know the usability and design should be improved, but<br>
I really don't care, if you dont like it remove it.<br><br>Gerhard<br><br><div class="gmail_quote">On Thu, Dec 24, 2009 at 3:53 PM, Lukas Renggli <span dir="ltr"><<a href="mailto:renggli@gmail.com">renggli@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">I don't like these changes.<br>
<br>
The goal of the tests is to demonstrate the concise implementation of<br>
some basic features. If the code and result is hidden by default this<br>
purpose is lost. Also the usability (clicking on the headings is not<br>
obvious) and the design (the boxes do not fit the existing css)<br>
doesn't look too nice in my eyes. What is the intent of your changes?<br>
<br>
Lukas<br>
<br>
2009/12/24 <<a href="mailto:squeak-dev-noreply@lists.squeakfoundation.org">squeak-dev-noreply@lists.squeakfoundation.org</a>>:<br>
> Gerhard Obermann uploaded a new version of JQuery-Tests-Core to project Seaside 3.0:<br>
> <a href="http://www.squeaksource.com/Seaside30/JQuery-Tests-Core-obi.97.mcz" target="_blank">http://www.squeaksource.com/Seaside30/JQuery-Tests-Core-obi.97.mcz</a><br>
><br>
> ==================== Summary ====================<br>
><br>
> Name: JQuery-Tests-Core-obi.97<br>
> Author: obi<br>
> Time: 24 December 2009, 3:26:11 pm<br>
> UUID: fbba5893-20dc-1641-b897-07ede0b0f8c7<br>
> Ancestors: JQuery-Tests-Core-lr.96, JQuery-Tests-Core-obi.95<br>
><br>
> - merged with obi.95<br>
><br>
> =============== Diff against JQuery-Tests-Core-lr.96 ===============<br>
><br>
> Item was changed:<br>
> ----- Method: JQAllTests>>renderSmalltalkOn: (in category 'rendering-browser') -----<br>
> renderSmalltalkOn: html<br>
> + | source id |<br>
> + id := html nextId.<br>
> + html heading level: 4;<br>
> + with: [html anchor<br>
> + onClick: ((html jQuery id: id) slideToggle: 0.5 seconds);<br>
> + with: 'Smalltalk'].<br>
> + html div<br>
> + id: id;<br>
> + class: 'hide codeBox';<br>
> + with: [<br>
> + contents selectors do: [ :selector |<br>
> + source := ((contents class whichClassIncludesSelector: selector)<br>
> + sourceCodeAt: selector) greaseString readStream.<br>
> + html div class: 'code'; with: [<br>
> + html span<br>
> + class: 'signature';<br>
> + with: [ html text: contents class name; text: '>>'; text: source nextLine ].<br>
> + html break.<br>
> + [ source atEnd ] whileFalse: [<br>
> + [ source peek = Character tab ] whileTrue: [<br>
> + html space; space; space.<br>
> + source next ].<br>
> + html render: source nextLine; break ] ] ]<br>
> + separatedBy: [ html break ] ]!<br>
> - | source |<br>
> - html heading level: 4; with: 'Smalltalk'.<br>
> - contents selectors do: [ :selector |<br>
> - source := ((contents class whichClassIncludesSelector: selector)<br>
> - sourceCodeAt: selector) greaseString readStream.<br>
> - html div class: 'code'; with: [<br>
> - html span<br>
> - class: 'signature';<br>
> - with: [ html text: contents class name; text: '>>'; text: source nextLine ].<br>
> - html break.<br>
> - [ source atEnd ] whileFalse: [<br>
> - [ source peek = Character tab ] whileTrue: [<br>
> - html space; space; space.<br>
> - source next ].<br>
> - html render: source nextLine; break ] ] ]<br>
> - separatedBy: [ html break ]!<br>
><br>
> Item was changed:<br>
> ----- Method: JQAllTestsLibrary>>defaultCss (in category 'styles') -----<br>
> defaultCss<br>
> ^ 'html { overflow-y: scroll; }<br>
> body { margin: 0; padding: 0; background: #434242 url(background.png) repeat-x; font-family: Helvetica,Arial,Verdana,sans-serif; font-size: 80%; line-height: 1.5; color: #222; }<br>
> a { text-decoration: none; color: #ff7200; outline: none; cursor: pointer; }<br>
> h1, h2, h3, h4, h5, h6 { border: 0; margin: 0; font-weight: normal; letter-spacing: 1px; }<br>
><br>
> #canvas { position: relative; margin: 0 auto; width: 1000px; }<br>
><br>
> #header h1.logo { float: left; margin: 50px 0; }<br>
> #header h1.logo a { display: block; width: 350px; height: 70px; background-image: url(logo.png); }<br>
> + #header h1.logo a span, #content .hide { display: none; }<br>
> - #header h1.logo a span { display: none; }<br>
><br>
> #menu { float: right; margin: 50px 0 10px 0; height: 50px; }<br>
> #menu .left, #menu .right { width: 15px; height: 50px; float: left; }<br>
> #menu .left { background-image: url(menuLeft.png); }<br>
> #menu .right { background-image: url(menuRight.png); }<br>
> #menu ul { background-image: url(menu.png); }<br>
> #menu ul, #menu ul li { float: left; margin: 0; padding: 0; height: 50px; list-style-type: none; }<br>
> #menu ul li a { padding: 0 15px; color: #bbb; line-height: 50px; font-size: 14px; }<br>
> #menu ul li a:hover { color: #fff; }<br>
><br>
> #content { position: relative; margin-bottom: 15px; }<br>
> #content { clear: both; background-color: white; }<br>
> + #content .codeBox {border:1px solid #ccc; overflow:auto; width:100%; height:400px}<br>
> #content .top,<br>
> #content .bottom { height: 15px; background: url(frame.png); }<br>
> #content .head, .body { border: 1px solid #ddd; }<br>
> #content .head { height: 70px; border-bottom: none; }<br>
> #content .head h2 { float: left; margin: 10px; color: #ff7200; line-height: 50px; font-size: 30px; }<br>
> #content .head p { float: left; margin: 10px; padding-left: 20px; line-height: 50px; font-size: 20px; border-left: 1px solid #ddd; }<br>
> #content .head { padding: 10px; }<br>
><br>
> #content .tests { position: relative; padding: 20px; float: left; width: 180px; border-right: 1px solid #ddd; }<br>
> #content .tests h3 { font-size: 20px; margin-bottom: 6px; color: #ff7200; }<br>
> #content .tests ul, #content .tests ul li { padding: 0; margin: 0; list-style-type: none; }<br>
> #content .tests ul { margin-bottom: 20px; }<br>
> #content .tests ul li { line-height: 25px; border-bottom: 1px solid #eee; }<br>
> #content .tests ul li.active { background-color: #ddd; border-bottom: 1px solid #ccc; }<br>
> #content .tests ul li a { padding-left: 10px; color: #222; text-decoration: none; display: block; }<br>
> #content .tests ul li a:hover { background:#eee; }<br>
><br>
> #content .main { position: relative; padding: 20px; float: left; width: 735px; border-left: 1px solid #ddd; margin-left: -1px; }<br>
> #content .main h3 { font-size: 20px; margin-bottom: 10px; }<br>
> #content .main h4 { font-size: 16px; border-bottom: 1px solid #eee; margin-top: 20px; margin-bottom: 10px; }<br>
> #content .main .demo { position: relative; }<br>
> #content .main .code { font-family: "Bitstream Vera Sans Mono", Courier, monospace; font-size: 1.2em; line-height: 1.2; overflow-x: hidden; overflow-y: auto; white-space: pre; width: 735px; }<br>
> #content .main .code .signature { font-weight: bold; }<br>
> #content .main .code .wa-tag { font-weight: bold; color: purple; }<br>
> #content .main .code .wa-attribute-key { font-weight: bold; color: black; }<br>
> #content .main .code .wa-attribute-value { color: blue; }<br>
> #content .main .code .wa-attribute-value a { color: blue; text-decoration: underline; }<br>
><br>
> .actions a { padding-right: 1em; }<br>
> #seastar { position: relative; }'!<br>
><br>
> Item was changed:<br>
> ----- Method: JQAllTests>>renderJavascriptOn: (in category 'rendering-browser') -----<br>
> renderJavascriptOn: html<br>
> + | context id |<br>
> + id := html nextId.<br>
> + html heading level: 4;<br>
> + with: [ html anchor<br>
> + onClick: ((html jQuery id: id) slideToggle: 0.5 seconds);<br>
> + with: 'Source'].<br>
> + html div id: id;<br>
> + class: 'code';<br>
> + class: 'hide';<br>
> + class: 'codeBox';<br>
> + with: [<br>
> + context := html context copy.<br>
> + context document: (WAPrettyPrintedDocument context: html context).<br>
> + contents renderWithContext: context.<br>
> + context document close ].!<br>
> - | context |<br>
> - html heading level: 4; with: 'Source'.<br>
> - html div class: 'code'; with: [<br>
> - context := html context copy.<br>
> - context document: (WAPrettyPrintedDocument context: html context).<br>
> - contents renderWithContext: context.<br>
> - context document close ].!<br>
><br>
><br>
> _______________________________________________<br>
> commits mailing list<br>
> To unsubscribe, email <a href="mailto:commits-leave@lists.seaside.st">commits-leave@lists.seaside.st</a><br>
> <a href="http://lists.seaside.st/listinfo/commits" target="_blank">http://lists.seaside.st/listinfo/commits</a><br>
><br>
<font color="#888888"><br>
<br>
<br>
--<br>
Lukas Renggli<br>
<a href="http://www.lukas-renggli.ch" target="_blank">http://www.lukas-renggli.ch</a><br>
_______________________________________________<br>
seaside-dev mailing list<br>
<a href="mailto:seaside-dev@lists.squeakfoundation.org">seaside-dev@lists.squeakfoundation.org</a><br>
<a href="http://lists.squeakfoundation.org/mailman/listinfo/seaside-dev" target="_blank">http://lists.squeakfoundation.org/mailman/listinfo/seaside-dev</a><br>
</font></blockquote></div><br>