Thanks Lukas!<br><br>See my answers below.<br><br><br>Cheers<br>Gerhard<br><br><div class="gmail_quote">On Wed, Dec 30, 2009 at 1:16 PM, Lukas Renggli <span dir="ltr"><<a href="mailto:renggli@gmail.com">renggli@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">Excellent.<br>
<br>
> - use passengers dictionary to keep a mapping between the id and the object<br>
<br>
I find the word passengers misleading, because is an established term<br>
in the realm of the Seaside Javascript support. I see that there are<br>
some common things but this is orthogonal and I would prefer to name<br>
it different (probably value).<br></blockquote><div><br>Ok, I would suggest valueDictionary<br></div><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<br>
> - use WA[Multi]PassengerCallback instead of WA[Multi]DispatcherCallback<br>
<br>
Why not keep the old name? Or name it WAValuesCallback and<br>
WAMultiValuesCallback?<br></blockquote><div> </div><div>because its still used by WARadioGroup, maybe I am able to change the behavior for RadioGroup too<br>I will rename it to WAValuesCallback<br><br></div><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<br>
> - no callback registering for option tags<br>
> - removed hidden input element from WAMultiSelectTag<br>
<br>
Excellent. We still have a hidden element for the checkbox? I guess we<br>
should get rid of that too, but that's presumably a different story.<br></blockquote><div><br>I will have a look at it later on! <br></div><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<br>
> - added nested multi selection test<br>
> - nested rendering code needs to be changed, because the callback must be defined<br>
> for the select tag only<br>
> - WAPassengerCallback stores the callbackBlock and the passengers dictionary<br>
<br>
I noticed that there is some commented code, please remove that before<br>
committing.<br></blockquote><div><br>Yes of course! <br></div><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<br>
Do the various Javascript tests still pass after this change?<br></blockquote><div> </div><div>No WACanvasBrushTest fails, but this will be fixed before the integration.<br><br></div><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<br>
Other than that this looks good to integrate.<br>
<br>
As a side note, Monticello expects branches to be named differently.<br>
I've updated the wiki:<br>
<a href="http://code.google.com/p/seaside/wiki/PackageNaming" target="_blank">http://code.google.com/p/seaside/wiki/PackageNaming</a>.<br>
<br>
Lukas<br>
<br>
2009/12/30 Gerhard Obermann <<a href="mailto:obi068@gmail.com">obi068@gmail.com</a>>:<br>
<div><div></div><div class="h5">> Hi!<br>
><br>
> I have uploaded a prototype for issue 374.<br>
> You can check it out by loading:<br>
><br>
> Seaside-Tests-Functional-Issue374-obi.98<br>
><br>
> Seaside-Core-Issue374-obi.595<br>
> Seaside-Canvas-Issue374-obi.76<br>
><br>
><br>
> See also the comments at:<br>
> <a href="http://code.google.com/p/seaside/issues/detail?id=374" target="_blank">http://code.google.com/p/seaside/issues/detail?id=374</a><br>
><br>
> Cheers<br>
> Gerhard<br>
><br>
><br>
><br>
><br>
</div></div>> _______________________________________________<br>
> seaside-dev mailing list<br>
> <a href="mailto:seaside-dev@lists.squeakfoundation.org">seaside-dev@lists.squeakfoundation.org</a><br>
> <a href="http://lists.squeakfoundation.org/mailman/listinfo/seaside-dev" target="_blank">http://lists.squeakfoundation.org/mailman/listinfo/seaside-dev</a><br>
><br>
><br>
<font color="#888888"><br>
<br>
<br>
--<br>
Lukas Renggli<br>
<a href="http://www.lukas-renggli.ch" target="_blank">http://www.lukas-renggli.ch</a><br>
_______________________________________________<br>
seaside-dev mailing list<br>
<a href="mailto:seaside-dev@lists.squeakfoundation.org">seaside-dev@lists.squeakfoundation.org</a><br>
<a href="http://lists.squeakfoundation.org/mailman/listinfo/seaside-dev" target="_blank">http://lists.squeakfoundation.org/mailman/listinfo/seaside-dev</a><br>
</font></blockquote></div><br>