So when you say hacked in, you mean I should try not to include these versions this weekend? :)<br><br>I'm afraid your question doesn't leave me with enough information to provide an opinion. Obviously faster == better, but what's the downside? I don't quite understand what the end result is.<br>
<br>Julian<br><br><div class="gmail_quote">On Thu, May 20, 2010 at 8:32 PM, Philippe Marschall <span dir="ltr"><<a href="mailto:philippe.marschall@gmail.com" target="_blank">philippe.marschall@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
Hi<br>
<br>
While hacking on an encoding prototype I found a way to improve<br>
Seaside rendering performance on Pharo. We spend quite a lot of time<br>
in WAEncoder >> #nextPutAll:. I realized I could use the same trick we<br>
use in for UTF-8 encoding. Most of the content we don't have to escape<br>
so if we can quickly decide that we don't need to escape the contents<br>
we can just do a #nextPutAll:. Pharo has a primitive for exactly this.<br>
<br>
So how much is it worth? The somewhat synthetic Seaside Performance<br>
Index goes through the roof (before [1] after [2]) and<br>
WALotsLinksFunctionalTest goes from about 900ms to about 500 ms.<br>
<br>
The code is in Grease-Core-pmm.38, Grease-Pharo-Core-pmm.20,<br>
Seaside-Core-pmm.636. Right now the code is hacked in and has a slow<br>
default fallback on GRPlatform. I believe I could make it a bit faster<br>
for cases where only very little content needs to be escaped (think a<br>
huge text block with a single & in the middle). The question is where<br>
we go from here, in the end we pretty much have methods for escaping<br>
XML and URL in platform with the current implementation on GRPlatform<br>
as fallback.<br>
<br>
[1] <a href="http://imgur.com/FftPH.png" target="_blank">http://imgur.com/FftPH.png</a><br>
[2] <a href="http://imgur.com/qlivp.png" target="_blank">http://imgur.com/qlivp.png</a><br>
<br>
Cheers<br>
Philippe<br>
_______________________________________________<br>
seaside-dev mailing list<br>
<a href="mailto:seaside-dev@lists.squeakfoundation.org" target="_blank">seaside-dev@lists.squeakfoundation.org</a><br>
<a href="http://lists.squeakfoundation.org/mailman/listinfo/seaside-dev" target="_blank">http://lists.squeakfoundation.org/mailman/listinfo/seaside-dev</a><br>
</blockquote></div><br>