I investigated this with Julian. Apologies for reiterating some of the ground already covered:<div><br></div><div><div class="wa-halo-header"><div class="wa-classnamehaloplugin">SUAllComponentTests class>>initialize </div>
<div class="wa-classnamehaloplugin">..... preferenceAt: #scriptGeneratorClass put: <b>PTScriptGenerator</b></div><div class="wa-classnamehaloplugin"><br></div><div class="wa-classnamehaloplugin">with a PTScriptGenerator anchors which contain an href and onclick handlers AND use "return false" in onClick to stop the href link from firing do not work as expected - The href link is activated. This is causing at least SUAccordion and SUCarousel to break in the current trunk. The problem can be fixed by replacing "return false" with "event.stop()". </div>
<div class="wa-classnamehaloplugin"><br></div><div class="wa-classnamehaloplugin">(WADispatcher default handlerAt: 'javascript/scriptaculous-components') preferenceAt: #scriptGeneratorClass put: nil</div><div class="wa-classnamehaloplugin">
results in working SUAccordion and SUCarousel without code changes.</div><div class="wa-classnamehaloplugin"><br></div><div class="wa-classnamehaloplugin"><div class="wa-classnamehaloplugin">(WADispatcher default handlerAt: 'javascript/scriptaculous-components') preferenceAt: #scriptGeneratorClass put: nil</div>
<div>and using the "event.stop()" code change also works.</div><div><br></div><div>a potential problem arises for users, with existing Scriptaculous code that use say <span class="Apple-style-span" style="font-family: arial, sans-serif; font-size: 13px; ">SUUpdater in an <span class="Apple-style-span" style="font-family: arial; font-size: small; ">onclick handler on an anchor with an href. When they update to the latest code alls well provided they don't start using PTScriptGenerator, in which case they have to change their "return false" to "event.stop()"</span></span></div>
</div><div class="wa-classnamehaloplugin"><br></div><div class="wa-classnamehaloplugin">thoughts?</div><div class="wa-classnamehaloplugin"><br></div><div class="wa-classnamehaloplugin">Nick</div><div class="wa-classnamehaloplugin">
<br></div><div class="wa-classnamehaloplugin"> </div></div></div>