<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">Hey Max,<div class=""><br class=""></div><div class="">Perhaps you can make a pull request on the git repo?</div><div class=""><br class=""></div><div class="">thx for the work</div><div class="">Johan</div><div class=""><br class=""></div><div class=""><div><blockquote type="cite" class=""><div class="">On 17 May 2017, at 06:49, Max Leske <<a href="mailto:maxleske@gmail.com" class="">maxleske@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><meta http-equiv="Content-Type" content="text/html charset=utf-8" class=""><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><meta http-equiv="Content-Type" content="text/html charset=utf-8" class=""><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><div class=""></div><blockquote type="cite" class=""><div class=""><br class=""><blockquote type="cite" class="">On 16 May 2017, at 22:24, Esteban A. Maringolo <<a href="mailto:emaringolo@gmail.com" class="">emaringolo@gmail.com</a>> wrote:<br class=""><br class="">2017-05-16 17:20 GMT-03:00 Max Leske <<a href="mailto:maxleske@gmail.com" class="">maxleske@gmail.com</a>>:<br class=""><blockquote type="cite" class="">Hi Philippe,<br class=""><br class="">I’ve created an implementation, trying to do what you suggest; these are the changes:<br class=""><br class="">- removed WADynamicVariable<br class="">- added GRDynamicVariable to Grease-Core<br class=""></blockquote></blockquote><br class="">Sorry, this should have been Grease-Pharo30-Core.<br class=""><br class=""><blockquote type="cite" class=""><blockquote type="cite" class="">- subclasses of WADynamicVariable now inherit from GRDynamicVariable<br class="">- test cases for WADynamicVariable moved to Grease-Tests-Core (not sure about this. The tests should be the same for all platforms but Grease-Core does not contain GRDynamicVariable…)<br class=""></blockquote><br class="">Great! Thank you Max.<br class=""><br class="">Is Grease-*Dialect*-Core (e.g. Grease-Pharo-Core) a prerequisite of Grease-Core?<br class=""></blockquote><br class="">No, the other way around, according to the configuration.<br class=""><br class=""><blockquote type="cite" class=""><br class=""><br class=""><blockquote type="cite" class="">I don’t have write permissions on STHub, so I’m attaching the patches below.<br class=""></blockquote><br class="">As expected, the file didn't make it to the attachments of the mail :)<br class=""></blockquote><br class="">Especially because I forgot to attach them… :p</div><div class=""><br class=""></div><div class="">Here’s the link to a zip archive with the patch: <a href="https://www.dropbox.com/s/pgd6k12mwh92s06/GRDynamicVariable_patch.zip?dl=0" class="">https://www.dropbox.com/s/pgd6k12mwh92s06/GRDynamicVariable_patch.zip?dl=0</a>.<br class=""></div></blockquote><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><br class=""></div><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">Just remembered something I forgot to fix. New archive: <a href="https://www.dropbox.com/s/44smqfnx4cvplt3/GRDynamicVariable_patch2.zip?dl=0" class="">https://www.dropbox.com/s/44smqfnx4cvplt3/GRDynamicVariable_patch2.zip?dl=0</a>.</div><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><br class=""></div><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">Max</div><br class=""><blockquote type="cite" class=""><div class=""><br class="">Cheers,<br class="">Max<br class=""><br class=""><blockquote type="cite" class=""><br class=""><blockquote type="cite" class="">I can also make the change for Squeak but I’m not sure how I would go about committing the change for VW / VASt. Let me know what you think.<br class=""></blockquote><br class=""><br class=""><br class=""><br class="">Esteban A. Maringolo<br class="">_______________________________________________<br class="">seaside-dev mailing list<br class=""><a href="mailto:seaside-dev@lists.squeakfoundation.org" class="">seaside-dev@lists.squeakfoundation.org</a><br class=""><a href="http://lists.squeakfoundation.org/mailman/listinfo/seaside-dev" class="">http://lists.squeakfoundation.org/mailman/listinfo/seaside-dev</a><br class=""></blockquote><br class=""></div></blockquote></div></div>_______________________________________________<br class="">seaside-dev mailing list<br class=""><a href="mailto:seaside-dev@lists.squeakfoundation.org" class="">seaside-dev@lists.squeakfoundation.org</a><br class="">http://lists.squeakfoundation.org/mailman/listinfo/seaside-dev<br class=""></div></blockquote></div><br class=""></div></body></html>