[Seaside] 2.5a5 ported to VW

Mon Jul 5 21:00:51 CEST 2004

On Jul 5, 2004, at 11:07 AM, Avi Bryant wrote:

>
> On Jul 5, 2004, at 9:41 AM, Bany, Michel wrote:
>
>> Avi,
>> During the tests I made on the port I discovered a few bugs, a couple
>> of STLINT "code critics" and a couple of VW compile warnings
>> The port includes some fixes for those bugs that are documented
>> in the attached document. You may want to check them so that you
>> can come up with the "official" fixes.
>
> Thanks, Michel.  I'll integrate these fixes as soon as possible.

I've updated SqueakMap to point to Seaside2.5a6-avi.2.mcz, which 
includes these fixes.  If you're interested, here are my notes on them:

--
Compile errors:
* WAComponent>>removeDecoration: - fixed
* WAComponent>>show:onAnswer: - not actually a problem

Bugs:

* Seaside fails when trying to enable halos on the WACanvasTest 
component -
this is indeed a bug, but I don't like the fix: it ought to be possible 
to enable halos on any component, regardless of which renderer class it 
uses.  I don't have a solution to this yet, but I don't see much value 
in including the workaround in the meantime; better to remind ourslves 
that this is broken.

* Seaside fails when the URL is an empty character string -
fixed.

* The HTML tag is not properly closed, <html<head> -
oops, fixed.

*In a composition, the last tag in a component may be left undisplayed, 
if its rendering class is a  kind of WACanvas -
fixed, though used #close as the polymorphic send across WARenderCanvas 
and WAHtmlRenderer to be more explicit.

* Missing block argument variable in exception handler -
fixed.

* Message sent but not implemented (WAPresenter>>decorationChainDo:) -
moved #renderOn: down to WAComponent instead.

* Method implemented but not sent 
(WARegistry>>expiredHandlerForRequest:) -
removed.

* IE6 requires </script>  -
fixed.

* WAStyleCollection doesn't check for nil attrs -
fixed.

* WACallbackStream, #upToEnd fails with sorted collection -
fixed.