[Seaside] 2.5a5 ported to VW

Avi Bryant avi at beta4.com
Tue Jul 6 19:44:02 CEST 2004


On Jul 6, 2004, at 4:34 AM, Bany, Michel wrote:

> > Compile errors:
> > * WAComponent>>removeDecoration: - fixed
> Some more change is needed:    
>                                 ...
>         "Here too ==>"  ifTrue: [dec owner: aDecoration owner.  ^ self]

Missed that, thank you.

> > * WAComponent>>show:onAnswer: - not actually a problem
> OK, but it would help for the port if the following statement was 
> added near the
> beginning of the method, if it does not hurt, of course :
>         event := nil.

Ok, sure.

> A fix to the bug could consist in adding to WARenderCanvas the 
> behavior that
> is expected by WAHalo (#divClass:with: #anchorWithAction:text: 
> #imageWithForm:).

Yes, but I don't want every renderer to have to implement those methods.

> Here is another possible suggestion for fixing the bug.
> Since it uses #divClass:with: #anchorWithAction:text: and 
> #imageWithForm:
> WAHalo expects a WAHtmlRenderer or a WARendererCompat as its renderer.
> On the other hand it also needs the renderer for the target component.
> This means that WAHalo needs two renderers.

Yes, I think your solution works.  It's a little messy, but Halos are a 
strange special case and are allowed to be messy...

Avi


More information about the Seaside mailing list