[Seaside] [Q] [Scriptaculous and Comet] SUStream related question

Philippe Marschall philippe.marschall at gmail.com
Sun Oct 15 08:51:40 UTC 2006


2006/10/15, Lukas Renggli <renggli at gmail.com>:
> > There is now a class called WAListenerEncoded that has the same
> > semantics as WAKomEncoded.
>
> WAKom, WAKomEncoded, WAKomEncoded39, WAListener, WAListernerEncoded,
> WAListenerEncoded39, WAListenerPlus, WAListernerEncoded39Plus, ... ;-)
>
> Why can't we just have a conversion strategy? As far as I remember
> this conversion happens when a Kom request/response is transformed
> from/to a Seaside request/respose. So it should be easy to factor that
> out into a strategy and avoid this ugly WAKom/WAListener class
> hierarchies, no?

Sure, traits.

WAListenerEncoded copy pastes one method from WAKomEncoded. They
contain only this method.
WAListenerEnoded39 and WAKomEncoded39 share no code. They contain only
one method.

WAKom and WAListener copy paste about two methods. It would probably
be a good idea to copy paste #processMultipartFields: too.
They could probably also share the class side.

Btw there's now no more duplication between WAKom and WAKomEncoded and
WAKomEncoded39.

Philippe


More information about the Seaside mailing list