philippe.marschall at gmail.com
Tue Jul 24 10:49:11 UTC 2007
2007/7/24, Michel Bany <michel.bany at gmail.com>:
> On 24 Jul 2007, at 09:34 , Philippe Marschall wrote:
> > 2007/7/24, Michael Lucas-Smith <mlucas-smith at cincom.com>:
> >> Hi,
> >> I'm currently using 2.8a1-pmm.411 and #testFragment fails in both
> >> Squeak
> >> and VisualWorks. Has anyone fixed this in a newer version?
> >> On the subject of tests - there's some weirdism with the test
> >> #testCompileByteArraySource. In VW, it goes down a path of
> >> #compileUseNewCompiler as the default is ^true.. this won't output a
> >> 'cache' variable and therefore the source doesn't match up. The test
> >> assumes that the compileUseNewCompiler is false but has no way to
> >> ensure
> >> that.
> > That's true. The test is broken, it tests platform specific stuff.
> > I'll recategorize it and make it work with new compiler.
> On the other hand, the test could be reworked to perform two
> different assertions
> based on #compileUseNewCompiler. The test would then pass in both Squeak
> and VW.
But #compileUseNewCompiler really only makes sense on Squeak. If we
want to keep that we should rename it to #useByteArrayLiterals which
on Squeak would send Preferences compileUseNewCompiler and on VW do
whatever makes sense there.
More information about the Seaside