[Seaside] Jetsam suggestion

[Sebastian Sastre]

HI there,
 
    I saw that:
 
WARegistry>>clearHandlers
 | handlers |
 self mutex critical: [
  handlers := handlersByKey.
  handlersByKey := SeasidePlatformSupport reducedConflictDictionary new.
  keysByHandler := SeasidePlatformSupport reducedConflictDictionary new ].
 handlers ifNotNil: [
  [ handlers do: [ :each | each unregistered ] ]
   fork ]
 
become overriden to:
 
 | handlers |
 self mutex critical: [
  handlers := handlersByKey.
  handlersByKey := SeasidePlatformSupport reducedConflictDictionary new.
  keysByHandler := SeasidePlatformSupport reducedConflictDictionary new ].
 handlers ifNotNil: [
  [ handlers do: [ :each | each unregistered ] ]
   fork ].
  
 ^ handlers size
 
code which in fact provides annoyances when handlers is nil. So my
suggestion is:
 
 | handlers |
 self mutex critical: [
  handlers := handlersByKey.
  handlersByKey := SeasidePlatformSupport reducedConflictDictionary new.
  keysByHandler := SeasidePlatformSupport reducedConflictDictionary new ].
 handlers ifNotNil: [
  [ handlers do: [ :each | each unregistered ] ]
   fork ].
  
 ^ handlers ifNil:[nil] ifNotNil:[handlers size]
 
    cheers,
 
Sebastian Sastre

 
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.squeakfoundation.org/pipermail/seaside/attachments/20071018/e4c0f65b/attachment.htm