[Seaside] [BUG] WAUrl>>scheme:

Bany, Michel mbany at cincom.com
Thu Oct 18 18:05:18 UTC 2007


Hi Boris,
Your tests pass just fine in Squeak. They fail in VW because
#displayString produces different answers in Squeak and VW when sent to
a symbol (in Squeak #foo displayString -> 'foo').
So I integrated your fix (and your tests) in Squeak
Seaside2.8a1-mb.510
Cheers,
Michel.



> -----Original Message-----
> From: seaside-bounces at lists.squeakfoundation.org 
> [mailto:seaside-bounces at lists.squeakfoundation.org] On Behalf 
> Of Boris Popov
> Sent: jeudi, 18. octobre 2007 19:20
> To: Seaside - general discussion
> Subject: [Seaside] [BUG] WAUrl>>scheme:
> 
> Using symbols in #serverProtocol preference breaks 
> suppression of port numbers in URL encoding for 80 and 443, 
> the following test would fail,
> 
> testSymbolScheme
>  url hostname: 'seaside.st'.
>  url port: 80; scheme: 'http'.
>  self assert: url displayString = 'http://seaside.st'.
>  url port: 443; scheme: 'https'.
>  self assert: url displayString = 'https://seaside.st'.
>  url port: 80; scheme: #http.
>  self assert: url displayString = 'http://seaside.st'.
>  url port: 443; scheme: #https.
>  self assert: url displayString = 'https://seaside.st'.
> 
> Interestingly enough even the setter suggests using symbols,
> 
> scheme: aSymbol
>  scheme := aSymbol
> 
> While it would certainly be nice to have one kind of object 
> there, for backwards compatibility I suggest we allow for both,
> 
> scheme: aSymbol
>  scheme := aSymbol asString
> 
> Thoughts?
> 
> -Boris
> 
> -- 
> +1.604.689.0322
> DeepCove Labs Ltd.
> 4th floor 595 Howe Street
> Vancouver, Canada V6C 2T5
> http://tinyurl.com/r7uw4
> 
> boris at deepcovelabs.com
> 
> CONFIDENTIALITY NOTICE
> 
> This email is intended only for the persons named in the 
> message header. Unless otherwise indicated, it contains 
> information that is private and confidential. If you have 
> received it in error, please notify the sender and delete the 
> entire message including any attachments.
> 
> Thank you.
> 
> _______________________________________________
> seaside mailing list
> seaside at lists.squeakfoundation.org
> http://lists.squeakfoundation.org/cgi-bin/mailman/listinfo/seaside
> 


More information about the seaside mailing list