[Seaside] [BUG] WAUrl>>scheme:

[Philippe Marschall]

I think the suggested type is bugous. We really expect a string.

Cheers
Philippe

2007/10/18, Boris Popov <boris at deepcovelabs.com>:
> Or even better switch exclusively to symbol and speed up suppression
> comparisons in encodeServerOn:
>
> scheme: aSymbol
>   scheme := aSymbol asSymbol
>
> ...
>
> scheme == #http , scheme == #https
>
> Cheers!
>
> -Boris
>
> --
> +1.604.689.0322
> DeepCove Labs Ltd.
> 4th floor 595 Howe Street
> Vancouver, Canada V6C 2T5
> http://tinyurl.com/r7uw4
>
> boris at deepcovelabs.com
>
> CONFIDENTIALITY NOTICE
>
> This email is intended only for the persons named in the message
> header. Unless otherwise indicated, it contains information that is
> private and confidential. If you have received it in error, please
> notify the sender and delete the entire message including any
> attachments.
>
> Thank you.
>
> > -----Original Message-----
> > From: seaside-bounces at lists.squeakfoundation.org [mailto:seaside-
> > bounces at lists.squeakfoundation.org] On Behalf Of Boris Popov
> > Sent: Thursday, October 18, 2007 10:20 AM
> > To: Seaside - general discussion
> > Subject: [Seaside] [BUG] WAUrl>>scheme:
> >
> > Using symbols in #serverProtocol preference breaks suppression of port
> > numbers in URL encoding for 80 and 443, the following test would fail,
> >
> > testSymbolScheme
> >  url hostname: 'seaside.st'.
> >  url port: 80; scheme: 'http'.
> >  self assert: url displayString = 'http://seaside.st'.
> >  url port: 443; scheme: 'https'.
> >  self assert: url displayString = 'https://seaside.st'.
> >  url port: 80; scheme: #http.
> >  self assert: url displayString = 'http://seaside.st'.
> >  url port: 443; scheme: #https.
> >  self assert: url displayString = 'https://seaside.st'.
> >
> > Interestingly enough even the setter suggests using symbols,
> >
> > scheme: aSymbol
> >  scheme := aSymbol
> >
> > While it would certainly be nice to have one kind of object there, for
> > backwards compatibility I suggest we allow for both,
> >
> > scheme: aSymbol
> >  scheme := aSymbol asString
> >
> > Thoughts?
> >
> > -Boris
> >
> > --
> > +1.604.689.0322
> > DeepCove Labs Ltd.
> > 4th floor 595 Howe Street
> > Vancouver, Canada V6C 2T5
> > http://tinyurl.com/r7uw4
> >
> > boris at deepcovelabs.com
> >
> > CONFIDENTIALITY NOTICE
> >
> > This email is intended only for the persons named in the message
> > header. Unless otherwise indicated, it contains information that is
> > private and confidential. If you have received it in error, please
> > notify the sender and delete the entire message including any
> > attachments.
> >
> > Thank you.
> >
> > _______________________________________________
> > seaside mailing list
> > seaside at lists.squeakfoundation.org
> > http://lists.squeakfoundation.org/cgi-bin/mailman/listinfo/seaside
> _______________________________________________
> seaside mailing list
> seaside at lists.squeakfoundation.org
> http://lists.squeakfoundation.org/cgi-bin/mailman/listinfo/seaside
>