[Seaside] I reported an error in error list - it was incorrectly classified as 'ignored'

[Avi Shefi]

Fritz,
Here's the actual generated code for your expression:

<button onclick="$(&quot;external_links a&quot;).click(function(){return
confirm(&quot;You are \&quot;going\&quot; to visit: &quot;+ this.href)})"
type="submit" class="submit">Attach Click</button>

This appears only on actual source code, and not any other Firebug-like
debuggers which convert HTML entities to their representations.
Cheers,
Avi.
On Sat, Feb 12, 2011 at 9:44 AM, Fritz Schenk
<intrader.intrader at gmail.com>wrote:

> http://code.google.com/p/seaside/issues/detail?id=640
> The problem remains and does not have to do with the source view as Julian
> suggests. The problem occurs because the expression: method String single
> quote 'external_links a' was changed to double quotes to "external_links
> a".
> Subsequent handling of the onClick: message encloses the entire construct
> in double quotes; hence the error as JavaScript does not accept embedded
> unescaped double quotes.
> This is a bug that needs to be address and not ignored.
> The analysis starts going wrong at Comment 4 and finally nailed in the
> coffin
> by comment 17
> This is not a bug in the Halo handling. the Seaside code is as follows:
> <code>
> renderContentOn: html
>        1 to: 5
>                do: [:x | html div id: 'external_links';
>
>                                with: [html anchor
>                                                callback: [x inspect];
>                                                 with: x]].
>        1 to: 5
>                do: [:x | html div id: '\"external_links\"';
>                                 with: 'just some content'].
> "the code for html button onClick: is incorrectly translated resulting in
> code that does not work"
> html button
> onClick: ((html jQuery expression: 'external_links a')
> onClick: 'return confirm("You are going to visit: "+ this.href)');
>                 with: 'Attach Click'
> </code>
>
> When the code does not work, the result is that 'inform' is executed
> without
> a prior execution of 'confirm'.
>
> _______________________________________________
> seaside mailing list
> seaside at lists.squeakfoundation.org
> http://lists.squeakfoundation.org/cgi-bin/mailman/listinfo/seaside
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.squeakfoundation.org/pipermail/seaside/attachments/20110212/4312343a/attachment.htm