[Seaside] GRPharoPlatform>>isIpAddress bug?

[AA]

I sent in this same report just a couple of weeks ago.  It's been fixed in the latest Seaside:

> Updates:
> 	Status: Duplicate
> 	Mergedinto: 646
> 
> Comment #1 on issue 687 by philippe... at gmail.com: Sending emails: error in  
> GRPharoPlatform>>isIpAddress:
> http://code.google.com/p/seaside/issues/detail?id=687
> 
> That's a duplicate of Issue 646 and is fixed in Seaside 3.0.4 and newer.

Amir


On Tue, 20 Sep 2011 10:59:14 -0400
"Marco A. Gonzalez" <marcoinc at mac.com> wrote:

> Hi,
> 
> I think I've discovered an problem in the following class>>method but still considering myself somewhat of a newbie, I'm not entirely sure:
> 
> GRPharoPlatform>>isIpAddress: aString
> 	| ip |
> 	ip := aString findTokens: '.'.
> 	^ ip size = 4
> 		and: [ ip allSatisfy: [ :each | each greaseInteger notNil
> 			and: [ each greaseInteger notNil between: 0 and: 255] ] ]
> 
> 
> The problem is the last line "each greaseInteger notNil between: 0 and: 255"... where the notNil message returns a true or false, and it does not respond to "between:and:". I believe the fix ought to be to remove the "notNil" in the last line to result in the line:
> 	 "each greaseInteger between: 0 and: 255" 
> since the "notNil" is already considered before the "and:".
> 
> 
> This is from the most recent One-click download:
> 	Pharo1.3
> 	Latest update: #13307
> 
> ------------------------------------------------------
> Marco A. Gonzalez
> 
> 
> 
> _______________________________________________
> seaside mailing list
> seaside at lists.squeakfoundation.org
> http://lists.squeakfoundation.org/cgi-bin/mailman/listinfo/seaside