[Seaside] Zinc as static file server

Sven Van Caekenberghe sven at beta9.be
Mon May 14 09:19:08 UTC 2012


On 12 May 2012, at 23:59, Sven Van Caekenberghe wrote:

> I'll have a look later on (I have little time this weekend).
> We also need at least one simple test (another one of Marcus' quotes; if there is no actively run test, it does not exist). We just need an extra version of #testIfModifiedSinceNotModified directly on a local server, it will require some setup, be it should be doable.

I integrated your changes and added 3 tests:


Name: Zinc-HTTP-SvenVanCaekenberghe.275
Author: SvenVanCaekenberghe
Time: 14 May 2012, 10:59:51 am
UUID: 94f2451b-b7e0-4d74-866b-d55b01c98ed9
Ancestors: Zinc-HTTP-PaulDeBruicker.274

refactored ZnStaticFileServerDelegate a bit:
- store expiration times as seconds in #defaultMimeTypeExpiration & #mimeTypeExpiration map
- add not only Cache-Control but Expires header as well
- removed unused #responseForFile:
fixed a bug in ZnMessage>>#clearEntity (didn't #close streaming entities with HEAD requests)


Name: Zinc-Tests-SvenVanCaekenberghe.142
Author: SvenVanCaekenberghe
Time: 14 May 2012, 11:11:41 am
UUID: 9f8498a3-c576-4844-a0f5-bafc5c5cbeca
Ancestors: Zinc-Tests-SvenVanCaekenberghe.141

added ZnStaticFileServerDelegateTests for
- expiration
- cache-control
- if-modified-since, not-modified


Have a look and tell me what you think.


Sven Van Caekenberghe
Smalltalk is the Red Pill

More information about the seaside mailing list