philippe.marschall at gmail.com
Tue Feb 25 21:40:19 UTC 2014
On Mon, Feb 24, 2014 at 7:50 PM, Johan Brichau <johan at inceptive.be> wrote:
> On 22 Feb 2014, at 22:54, Philippe Marschall <philippe.marschall at gmail.com> wrote:
>> That's a pretty simple fix
>> WAJsonObjectBrush >> #openBrush
>> canvas writeIfNotFirst: ', '.
>> self document openObject
>> seems to do the trick. I'm a bit reluctant to commit because I'm not
>> sure if it will break anything. Tests are green though.
> Though it is an interface change, perhaps it's the best thing to change it now (for 3.1.1) before too many people have migrated to Seaside 3.1 ?
The thing is I'm not sure it's an actual interface change. Sure, new
code written against the new version will not work against the old
version but I'm not sure that code written against the old version
> Mind that I am also changing the jQuery and jQueryUI packages to their latest versions, so 3.1.1 will have a couple of interface changes anyway. Unless we decide to postpone the jQuery upgrade (which is not a good idea imho) to 3.2 ?
Doing this now is correct IMHO.
More information about the seaside