<div>James,</div><div><br></div>It's been a while since I looked at the google maps stuff so I don't recall... what do you actually render to the page? If memory serves, you only need to output stuff that can be generated by the standard brushes (divs and JS or something, right?) and you don't need to put content inside it.<div>
<br></div><div>I have no memory of whether there is anything that requires a component to keep state but it doesn't *seem* at first glance to me like something that needs to be a brush either. I don't mean to suggest you're wrong since you've obviously gone through the exercise and I haven't but there's quite a bit of debate now and then over when to use brushes. I'm just wondering whether you considered a renderable object (a Painter in 2.9) as an option or just component/brush. And if you ruled out the third option, is there a particular reason you think a brush is more appropriate?</div>
<div><br></div><div>Julian</div><div><br><div class="gmail_quote">On Thu, Jun 18, 2009 at 4:00 PM, James Foster <span dir="ltr"><<a href="mailto:Smalltalk@jgfoster.net">Smalltalk@jgfoster.net</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
<div style="word-wrap:break-word">Mariano,<div><br></div><div>I'll be interested to see how this comes out. As I mentioned earlier, I started with a component and switched to a brush. I came to view the GoogleMap as a browser widget, something like a listbox, where you give it some data and let it draw itself. Yes, you can configure callbacks, but that isn't really different from other brushes. What sort of 'state' do you envision keeping with the map? Might that be better in a domain-specific component that wraps a map? I was able to implement over 40 examples and have not yet found a need to get more complex.<div>
<br></div><font color="#888888"><div>James</div></font><div><div></div><div class="h5"><div><br><div><div>On Jun 18, 2009, at 2:58 PM, Mariano Montone wrote:</div><br><blockquote type="cite">Thanks Julian. I think a component will be ok.<br>
<br>Mariano<br><br><div class="gmail_quote">On Thu, Jun 18, 2009 at 1:22 PM, Julian Fitzell <span dir="ltr"><<a href="mailto:jfitzell@gmail.com" target="_blank">jfitzell@gmail.com</a>></span> wrote:<br> <blockquote class="gmail_quote" style="border-left:1px solid rgb(204, 204, 204);margin:0pt 0pt 0pt 0.8ex;padding-left:1ex">
<div>Hi Mariano,</div><div><br></div>Off the top of my head, if I were implementing a google maps package, I would do it as a component or a painter (see below). Brushes certainly aren't intended to be kept around so if you have state to persist between requests that's not the way to go.<br>
<br><div>There are people who like implementing everything as brushes but the main functionality of brushes is that they can be selected in arbitrary orders to nest content within each other, e.g.:</div><div><br></div><div>
html div: [ html span: [ html paragraph: 'foo' ] ].</div><div><br></div><div>Unless you plan to do be able to do:</div><div><br></div><div>html div: [ html googleMap: [ html paragraph: 'foo' ] ]</div><div>
<br></div><div>(i.e. unless the thing you are creating allows content to be put inside it) I don't think there's much advantage in making your own brush. (The other reason to consider using brushes of course is that they have more direct access to the document).</div>
<div><br></div><div>Even if you don't need the benefits of components (see <a href="http://blog.fitzell.ca/2009/05/when-to-use-seaside-component.html" target="_blank">http://blog.fitzell.ca/2009/05/when-to-use-seaside-component.html</a> ), you can just create a renderable object by implementing #renderOn: and do:</div>
<div><br></div><div>html render: (GoogleMaps new configSomeStuff; yourself)</div><div><br></div><div>This process is made much clearer in 2.9 where you can subclass WAPainter, implement #rendererClass to control what kind of renderer you get passed (you might possibly implement the google maps thing *using* one or more custom brushes and have your own renderer for them), and implement #renderContentOn: as you would for a component.</div>
<div><br></div><div>Hopefully that makes things clearer and not muddier. :)</div><div><br><div>Julian</div><div><br><div class="gmail_quote"><div><div></div><div>On Thu, Jun 18, 2009 at 5:51 AM, Mariano Montone <span dir="ltr"><<a href="mailto:marianomontone@gmail.com" target="_blank">marianomontone@gmail.com</a>></span> wrote:<br>
</div></div><blockquote class="gmail_quote" style="border-left:1px solid rgb(204, 204, 204);margin:0pt 0pt 0pt 0.8ex;padding-left:1ex"><div><div></div><div>Hello!,<br> I'm implementing an API for rendering Google Maps. I've decided to implement it as a brush. That's because I'm just generating javascript code. But now I have a problem: when adding support for callbacks, I need to hold some state; for example, the map the callback refers to. But I think brushes are not meant to hold state, that is something left for the components mechanism, isn't it? So I would like to know what would be the correct way of implementing it in the framework. Should I implement maps as components, or should I add state to my brushes; I may hold a state in the callback block too, but I don't think that's good.<br>
<br>Thanks!<br><font color="#888888"><br>Mariano<br><br><br> </font><br></div></div><div>_______________________________________________<br> seaside mailing list<br> <a href="mailto:seaside@lists.squeakfoundation.org" target="_blank">seaside@lists.squeakfoundation.org</a><br>
<a href="http://lists.squeakfoundation.org/cgi-bin/mailman/listinfo/seaside" target="_blank">http://lists.squeakfoundation.org/cgi-bin/mailman/listinfo/seaside</a><br> <br></div></blockquote></div><br></div></div> <br>_______________________________________________<br>
seaside mailing list<br> <a href="mailto:seaside@lists.squeakfoundation.org" target="_blank">seaside@lists.squeakfoundation.org</a><br> <a href="http://lists.squeakfoundation.org/cgi-bin/mailman/listinfo/seaside" target="_blank">http://lists.squeakfoundation.org/cgi-bin/mailman/listinfo/seaside</a><br>
<br></blockquote></div><br> _______________________________________________<br>seaside mailing list<br><a href="mailto:seaside@lists.squeakfoundation.org" target="_blank">seaside@lists.squeakfoundation.org</a><br><a href="http://lists.squeakfoundation.org/cgi-bin/mailman/listinfo/seaside" target="_blank">http://lists.squeakfoundation.org/cgi-bin/mailman/listinfo/seaside</a><br>
</blockquote></div><br></div></div></div></div></div><br>_______________________________________________<br>
seaside mailing list<br>
<a href="mailto:seaside@lists.squeakfoundation.org">seaside@lists.squeakfoundation.org</a><br>
<a href="http://lists.squeakfoundation.org/cgi-bin/mailman/listinfo/seaside" target="_blank">http://lists.squeakfoundation.org/cgi-bin/mailman/listinfo/seaside</a><br>
<br></blockquote></div><br></div>