Hi Sean,<br><br>Not sure... I guess we either put the instVar on the abstract ServerAdaptor and ignore it on subclasses that don't support it or you just implement it on the Swazoo adaptor and we pull it up whenever we're ready to implement it elsewhere. I don't think it matters too much, so just do what's easiest. If the ListenerAdaptor is using HTTP internals direectly enough that it's easy, that would be a good reason to pull it up.<br>
<br>If you feel like chasing up Göran/Giovanni to see about extending Comanche to support it, though, that would be awesome!<br><br>And, yes, it would be nice to have support for it in the control panel if you don't mind. Just default to 0.0.0.0 on creation and add a command to change it I guess?<br>
<br>Julian<br><br><div class="gmail_quote">On Tue, Apr 20, 2010 at 2:24 AM, Sean Allen <span dir="ltr"><<a href="mailto:sean@monkeysnatchbanana.com">sean@monkeysnatchbanana.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
Julian,<br>
<br>
I did this for Swazoo. It was 5 minutes of work.<br>
I haven't done for Comanche yet, wanted to get some feedback first.<br>
<br>
The Comanche adapter uses HTTPService which descends from TcpService<br>
to register itself.<br>
TcpService has the ability in theory to do ip and port because of this<br>
instance side method:<br>
<br>
initializeOnPort:address:priority:<br>
<br>
However, nowhere else in the comanche code can i see it ever using the<br>
priority or address anywhere.<br>
>From what I can see, its incomplete and only capable at this time of<br>
doing by port. The Comanche code is<br>
obviously outside the scope of seaside so I'm not sure how to proceed.<br>
<br>
Should I only implement for Swazoo ( done ) and call it a day or<br>
should I talk to Goran about adding the required functionality<br>
to Comanche and hold back the changes til then.<br>
<br>
Additionally, should I an additional popup when configuring an adaptor<br>
via the control panel so that it prompts for port and ip or should<br>
i leave this as functionality you can get at if you don't use the<br>
control panel? I need this for running on Gemstone<br>
so control panel isn't an issue for me, but I can add if its desired.<br>
<br>
Last but not least, the listener adapter, add functionality to it as<br>
well? ( I haven't looked at it yet in anything other than a cursory<br>
fashion ).<br>
And the test adapter, not needed for that correct?<br>
<font color="#888888"><br>
-Sean-<br>
</font><div><div></div><div class="h5"><br>
<br>
<br>
On Tue, Mar 30, 2010 at 4:08 AM, Julian Fitzell <<a href="mailto:jfitzell@gmail.com">jfitzell@gmail.com</a>> wrote:<br>
> On Tue, Mar 30, 2010 at 1:44 AM, Sean Allen <<a href="mailto:sean@monkeysnatchbanana.com">sean@monkeysnatchbanana.com</a>> wrote:<br>
>> On Mon, Mar 29, 2010 at 7:06 PM, Julian Fitzell <<a href="mailto:jfitzell@gmail.com">jfitzell@gmail.com</a>> wrote:<br>
>>> Ok, fair enough. And yes we should add it. (isn't there an issue open<br>
>>> for that somewhere?)<br>
>>><br>
>><br>
>> I dont think so,<br>
><br>
> Here it is:<br>
><br>
> <a href="http://code.google.com/p/seaside/issues/detail?id=360" target="_blank">http://code.google.com/p/seaside/issues/detail?id=360</a><br>
><br>
>>> The question I guess is how should you specify the interface? Is an IP<br>
>>> string good enough?<br>
>>><br>
>><br>
>> Yes.<br>
>><br>
>> I already did the work for the Swazoo adapter.<br>
>> I'll take on the work of doing that and the others.<br>
>> Its my itch, I'll scratch it.<br>
>><br>
>> Should I do for 2.8 and 3.0 or just 3.0?<br>
>><br>
>> Is the best thing to do:<br>
>><br>
>> create an issue.<br>
>> attached .mcz files to the issue<br>
><br>
> Sure, or upload to:<br>
><br>
> MCHttpRepository<br>
> location: '<a href="http://www.squeaksource.com/SeasideInbox" target="_blank">http://www.squeaksource.com/SeasideInbox</a>'<br>
> user: ''<br>
> password: ''<br>
><br>
> Julian<br>
</div></div><div><div></div><div class="h5">> _______________________________________________<br>
> seaside mailing list<br>
> <a href="mailto:seaside@lists.squeakfoundation.org">seaside@lists.squeakfoundation.org</a><br>
> <a href="http://lists.squeakfoundation.org/cgi-bin/mailman/listinfo/seaside" target="_blank">http://lists.squeakfoundation.org/cgi-bin/mailman/listinfo/seaside</a><br>
><br>
_______________________________________________<br>
seaside mailing list<br>
<a href="mailto:seaside@lists.squeakfoundation.org">seaside@lists.squeakfoundation.org</a><br>
<a href="http://lists.squeakfoundation.org/cgi-bin/mailman/listinfo/seaside" target="_blank">http://lists.squeakfoundation.org/cgi-bin/mailman/listinfo/seaside</a><br>
</div></div></blockquote></div><br>