No, I think we (I?) had imagined people implementing more or less complete ResponseGenerators themselves. But that said, there&#39;s no reason not to do a refactoring like the below the make it easier to change just that.<br>

<br>I would suggest extracting all the creation and modification of the URL into a method #expiryUrl, which you could override to call &quot;^ super expiryUrl addParameter: ...&quot;. Would that work or do you need to do your modification at that exact point? If that&#39;s ok, maybe you could file an issue in the tracker?<br>

<br>Julian<br><br><div class="gmail_quote">On Wed, May 5, 2010 at 1:20 PM, Boris Popov, DeepCove Labs (YVR) <span dir="ltr">&lt;<a href="mailto:boris@deepcovelabs.com">boris@deepcovelabs.com</a>&gt;</span> wrote:<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">










<div link="blue" vlink="purple" lang="EN-IE">

<div>

<p class="MsoNormal">I&#39;d like to addParameter: &#39;expired&#39; to the redirect URL when
sessions expire, is there a clean way of customizing the URL on the subclass of
WAResponseGenerator without copy-pasting the whole body of #expiredKey? I&#39;m
thinking of,</p>

<p class="MsoNormal"> </p>

<p class="MsoNormal">WAResponseGenerator&gt;&gt;expiredKey</p>

<p class="MsoNormal"> </p>

<p class="MsoNormal">                |
url |</p>

<p class="MsoNormal">                self
request isXmlHttpRequest</p>

<p class="MsoNormal">                                ifTrue:
[ ^ self forbidden ].</p>

<p class="MsoNormal">                url
:= WAUrl new.</p>

<p class="MsoNormal">                url
addAllToPath: self request url path.</p>

<p class="MsoNormal">                <b><u>self
expiryPathOn: url.</u></b></p>

<p class="MsoNormal">                url
takeServerParametersFromRequest: self request.</p>

<p class="MsoNormal">                self
request isGet ifTrue: [</p>

<p class="MsoNormal">                                self
request fields keysAndValuesDo: [ :key :value |</p>

<p class="MsoNormal">                                                (url
isSeasideField: key) </p>

<p class="MsoNormal">                                                                ifFalse:
[ url addField: key value: value ] ] ].</p>

<p class="MsoNormal">                self
response redirectTo: url</p>

<p class="MsoNormal"> </p>

<p class="MsoNormal">Then you&#39;d only need to add your own,</p>

<p class="MsoNormal"> </p>

<p class="MsoNormal">MyOwnResponseGenerator&gt;&gt;expiryPathOn: url</p>

<p class="MsoNormal"> </p>

<p class="MsoNormal">                url
addParameter: &#39;expired&#39;</p>

<p class="MsoNormal"> </p>

<p class="MsoNormal">Perhaps I&#39;d overlooked some other way of achieving this w/o
modifying core?</p>

<p class="MsoNormal"> </p>

<p class="MsoNormal">Regards,</p>

<p class="MsoNormal"> </p>

<p class="MsoNormal">-Boris</p>

<p class="MsoNormal"> </p>

<p class="MsoNormal">-- </p>

<p class="MsoNormal">DeepCove Labs Ltd.</p>

<p class="MsoNormal">+1 (604) 689-0322</p>

<p class="MsoNormal">4th floor, 595 Howe Street</p>

<p class="MsoNormal">Vancouver, British Columbia</p>

<p class="MsoNormal">Canada V6C 2T5</p>

<p class="MsoNormal"><a href="http://tinyurl.com/r7uw4" target="_blank">http://tinyurl.com/r7uw4</a></p>

<p class="MsoNormal"> </p>

<p class="MsoNormal">PacNet Services (Europe) Ltd.</p>

<p class="MsoNormal">+353 (0)61 714-360</p>

<p class="MsoNormal">Shannon Airport House, SFZ</p>

<p class="MsoNormal">County Clare, Ireland</p>

<p class="MsoNormal"><a href="http://tinyurl.com/y952amr" target="_blank">http://tinyurl.com/y952amr</a></p>

<p class="MsoNormal"> </p>

<p class="MsoNormal">CONFIDENTIALITY NOTICE</p>

<p class="MsoNormal"> </p>

<p class="MsoNormal">This email is intended only for the persons named in the
message header. Unless otherwise indicated, it contains information that is
private and confidential. If you have received it in error, please notify the
sender and delete the entire message including any attachments.</p>

<p class="MsoNormal"> </p>

<p class="MsoNormal">Thank you.</p>

<p class="MsoNormal"> </p>

</div>

</div>


<br>_______________________________________________<br>
seaside mailing list<br>
<a href="mailto:seaside@lists.squeakfoundation.org">seaside@lists.squeakfoundation.org</a><br>
<a href="http://lists.squeakfoundation.org/cgi-bin/mailman/listinfo/seaside" target="_blank">http://lists.squeakfoundation.org/cgi-bin/mailman/listinfo/seaside</a><br>
<br></blockquote></div><br>