<br><br><div class="gmail_quote">On Sat, Dec 25, 2010 at 9:19 PM, Tony Fleig <span dir="ltr"><<a href="mailto:tony.fleig@gmail.com">tony.fleig@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
I am confused.<div><br></div><div>I have some changes to MailMessage (a Pharo class) and WAEmailMessage (a Seaside class) and an extension to MailMessage (the method MailMessage>>seasideEmailMessage:from:to:subject:) that I would like to contribute. These changes allow multi-part MIME messages to be created and sent from a Seaside web applicationfo -- r example messages with an HTML part and a plain text part.</div>
<div><br></div><div>Following the instructions at <a href="http://code.google.com/p/pharo/wiki/HowToContribute" target="_blank">http://code.google.com/p/pharo/wiki/HowToContribute</a>, I am installing my changes into Pharo 1.2 in preparation for creating a Monticello package for PharoInbox. Here are my problems:</div>
<div><br></div><div>1. One of the steps is "File in your changes and test." I have test classes derived from Sunit. Pharo 1.2 core doesn't seem to include Sunit. Should I test manually and not include the Sunit tests in the package I submit?</div>
<div><br></div><div>2. I assume the MailMessage extension described above belongs in a Seaside update. Is this true?</div></blockquote><div><br>Yes, I guess so. <br> </div><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<div><br></div><div>3. The Seaside changes cannot load without first loading the Pharo changes since the multi-part message is created using Pharo's MailMessage . How is this kind of dependency handled? Should I wait for a Seaside distribution on a version of Pharo that includes my changes before submitting the Seaside package? It seems like this could take a long time.</div>
<div><br></div></blockquote><div><br>I think this is a little complicated case ;)<br>So...My suggestions is:<br><br>- First, ask in both mailing list if both parts are interested in such fixes. I guess both will be.<br>- Then, integrate the fix in Pharo (changes to MailMessage and tests)<br>
- Once this is integrated in Pharo, you can ask Seaside developers to commit the part of seaside.<br><br> </div><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<div></div><div>4. Should I make this a Seaside-only package and extend Pharo's MailMessage in that package?</div><div><br></div></blockquote><div><br>I don't know.I cc'ed the seaside developers.<br><br>Cheers<br>
<br>mariano<br> </div><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;"><div></div><div>Any advice will be appreciated.</div><div><br></div><div>
Cheers,</div><div>TF</div><font color="#888888">
<div><br></div><div><br></div>
</font></blockquote></div><br>