Hi Sven,<div><br></div><div>Could you simply update #stable version in ConfigurationOfZincHTTPComponents to reflect your recent changes. Then I think ConfigurationOfSeaside30 should load the correct version. Of course the one-click and developer builds will still need to updated</div>
<div><br></div><div>Cheers</div><div><br></div><div>Nick</div><div><div><br><div class="gmail_quote">On 4 April 2012 09:07, Sven Van Caekenberghe <span dir="ltr"><<a href="mailto:sven@beta9.be">sven@beta9.be</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Nick,<br>
<div><div class="h5"><br>
On 04 Apr 2012, at 08:52, Nick Ager wrote:<br>
<br>
> Hi Sven,<br>
><br>
> ---<br>
> Name: Zinc-HTTP-SvenVanCaekenberghe.248<br>
> Author: SvenVanCaekenberghe<br>
> Time: 4 March 2012, 8:25:19 pm<br>
> UUID: aaab5645-ed48-4174-bdb5-53037fb297db<br>
> Ancestors: Zinc-HTTP-SvenVanCaekenberghe.247<br>
><br>
> Switched ZnServer class>>#defaultServerClass to ZnManagingMultiThreadedServer;<br>
> […]<br>
> ---<br>
><br>
> ZnManagingMultiThreadedServer differs from its superclass ZnMultiThreadedServer in that it keeps explicit track of each (kept-alive) client connection. Tracking open client connections is important to correctly handle the case where people save an image with a running server. Before, that sometimes resulted in crashes of all kinds because even though the server (socket) itself came back up correctly, it happened that client worker process kept reading or writing to (now) stale socket streams. Now, when the server shuts down (#stop's) it closes all client connections explicitly.<br>
><br>
> Currently the 3.0.7 one-click and developer images use ZnMultiThreadedServer rather than ZnManagingMultiThreadedServer and ConfigurationOfSeaside30 loads the stable configuration of Zinc which doesn't incorporate the change to #defaultServerClass to move from ZnMultiThreadedServer to ZnManagingMultiThreadedServer.<br>
><br>
> From your description above it sounds as though images uses ZnMultiThreadedServer could experience crashes. Is is worth updating the #stable version in ConfigurationOfZincHTTPComponents and the 3.0.7 one-click and developer images as Zinc is now used as the default server adaptor?<br>
><br>
> Cheers<br>
><br>
> Nick<br>
<br>
</div></div>Thanks a lot for taking care and pushing this.<br>
<br>
Yes it would be a good idea to use a later version with the new default.<br>
<br>
Pharo 1.3/1/4 need another Zn update as well (the latest integrated version was Zinc-HTTP-SvenVanCaekenberghe.242). I will create a new issue for that.<br>
<br>
It is (and has been) possible to explicitely use ZnManagingMultiThreadedServer, like this:<br>
<div class="im"><br>
ZnZincServerAdaptor new<br>
port: 8080;<br>
serverClass: ZnManagingMultiThreadedServer;<br>
start<br>
<br>
</div>Or we could change ZnZincServerAdaptor to use that class by default.<br>
<br>
I would prefer the full Zn update, I guess, but that is the most work.<br>
<div class="HOEnZb"><div class="h5"><br>
Sven<br>
<br>
<br>
--<br>
Sven Van Caekenberghe<br>
<a href="http://stfx.eu" target="_blank">http://stfx.eu</a><br>
Smalltalk is the Red Pill<br>
<br>
<br>
<br>
<br>
</div></div><br>_______________________________________________<br>
seaside mailing list<br>
<a href="mailto:seaside@lists.squeakfoundation.org">seaside@lists.squeakfoundation.org</a><br>
<a href="http://lists.squeakfoundation.org/cgi-bin/mailman/listinfo/seaside" target="_blank">http://lists.squeakfoundation.org/cgi-bin/mailman/listinfo/seaside</a><br>
<br></blockquote></div><br></div></div>