<div dir="ltr">Hi Sven,<div><br></div><div style>thanks for the answers. My REST services are really simple, for example there is a list of users:</div><div style><br></div><div style><div><font face="courier new, monospace">GPRestfulHandler>>getUsers</font></div>
<div><font face="courier new, monospace"><br></font></div><div><font face="courier new, monospace"><span class="" style="white-space:pre"> </span><get></font></div><div><font face="courier new, monospace"><span class="" style="white-space:pre"> </span><path: 'user/list'></font></div>
<div><font face="courier new, monospace"><span class="" style="white-space:pre"> </span><produces: 'application/json; charset=utf-8'></font></div><div><font face="courier new, monospace"><span class="" style="white-space:pre"> </span>| instance container items |</font></div>
<div><font face="courier new, monospace"><span class="" style="white-space:pre"> </span>instance := GPUser new.</font></div><div><font face="courier new, monospace"><span class="" style="white-space:pre"> </span>container := instance descriptionId , instance descriptionLogin.</font></div>
<div><font face="courier new, monospace"><span class="" style="white-space:pre"> </span>items := self database getUsers.</font></div><div><font face="courier new, monospace"><span class="" style="white-space:pre"> </span>^ (items collect: [ :item | item asDictionaryFrom: container ]) asJson</font></div>
<div><br></div><div style>There is a JSON result:</div><div style><br></div><div style><pre style="color:rgb(0,0,0);word-wrap:break-word;white-space:pre-wrap"><font face="courier new, monospace">[{"Id":"688a7ymp9zn60qczvvyniprwq","Login":"tomas"},{"Id":"av0t1s9u4ddu747hd2xyfi58","Login":"petr"}]</font></pre>
</div><div style>Detail of user can be read by this method:</div><div style><br></div><div style><span style="font-family:'courier new',monospace">GPRestfulHandler>></span><font face="courier new, monospace">getUserByLogin: aLogin<br>
</font></div><div><br></div><div><font face="courier new, monospace"><span class="" style="white-space:pre"> </span><get></font></div><div><font face="courier new, monospace"><span class="" style="white-space:pre"> </span><path: 'user/detail/by-login/{aLogin}'></font></div>
<div><font face="courier new, monospace"><span class="" style="white-space:pre"> </span><produces: 'application/json; charset=utf-8'></font></div><div><font face="courier new, monospace"><span class="" style="white-space:pre"> </span>| user |</font></div>
<div><font face="courier new, monospace"><span class="" style="white-space:pre"> </span>user := self database getUserByLogin: aLogin.</font></div><div><font face="courier new, monospace"><span class="" style="white-space:pre"> </span>user isNil</font></div>
<div><font face="courier new, monospace"><span class="" style="white-space:pre"> </span>ifFalse: [ ^ user asJson ]</font></div><div><font face="courier new, monospace"><span class="" style="white-space:pre"> </span>ifTrue: [ self respondAsUserWasNotFindByLogin: aLogin ]</font></div>
<div style><br></div><div style>Result is here. I had to fix the failing ByteArray method to get GoalName with Czech characters:</div><div style><pre style="color:rgb(0,0,0);word-wrap:break-word;white-space:pre-wrap"><font face="courier new, monospace">{"Id":"688a7ymp9zn60qczvvyniprwq","Login":"tomas","CurrentAccountBalance":12000,"SavingsAccountReserve":0,"SavingsAccountHeap":0,"InterestRate":1,"PaymentDay":15,"SimulationDate":"29 May 2013","SavingsAccountInterestReserve":0,"SavingsAccountInterestHeap":0,"Goals":[{"GoalName":"ěščřžýáíé-ĚŠČŘŽÝÁÍÉ","GoalAmount":8000,"MaturityDate":"29 November 2013"}],"Plans":[{"PaymentDate":"29 May 2013","PaymentAmount":1140.410292918764},{"PaymentDate":"29 June 2013","PaymentAmount":1140.410292918764},{"PaymentDate":"29 July 2013","PaymentAmount":1140.410292918764},{"PaymentDate":"29 August 2013","PaymentAmount":1140.410292918764},{"PaymentDate":"29 September 2013","PaymentAmount":1140.410292918764},{"PaymentDate":"29 October 2013","PaymentAmount":1140.410292918764},{"PaymentDate":"29 November 2013","PaymentAmount":1140.410292918764}]}</font><br>
</pre></div><div style><br></div><div style>Can you see any problem with the REST method?</div><div style><br></div><div style>Tomas</div></div><div style><br></div></div><div class="gmail_extra"><br><br><div class="gmail_quote">
On Wed, Jun 26, 2013 at 2:00 PM, Sven Van Caekenberghe <span dir="ltr"><<a href="mailto:sven@stfx.eu" target="_blank">sven@stfx.eu</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Hi Tomas,<br>
<div class="im"><br>
On 26 Jun 2013, at 13:20, Tomas Kukol <<a href="mailto:tomas.kukol@gmail.com">tomas.kukol@gmail.com</a>> wrote:<br>
<br>
> Hi Sven,<br>
><br>
> you are right. Seaside needs it as a string. But I've found another problem with output (maybe because Seaside uses string???) which leads to error 'Improper store into indexable object'.<br>
><br>
> I have JSON on output. It is again string and there is this problem. In ZnZincServerAdaptor>>responseFrom: we are asking for contents.<br>
<br>
</div>I don't know much about Seaside-REST but I would guess, from my general understanding how Seaside works, that if you generate output, like JSON, your output has to pass through an encoder before it is stored as bytes (well actually a ByteString, but that is another story) inside RWBinaryOrTextStream's contents of the WABufferedResponse. The encoder will make sure WideCharacters get encoded properly and then the #replaceFrom:to:with:startingAt: will work (and magically bridge the ByteArray/ByteString gap).<br>
<br>
So my guess is that you either have not set the proper encoder on the response when writing output to it, or you write the output the wrong way.<br>
<br>
There has to be a codec stream in between. See<br>
<br>
WAServerAdaptor>>#responseFor:<br>
GRPharoUtf8Codec>>#encoderFor:<br>
<br>
HTH,<br>
<br>
Sven<br>
<div class="HOEnZb"><div class="h5"><br>
> ZnZincServerAdaptor>>responseFrom: aRequestContext<br>
> | partialHeaders cookies fullHeaders seasideResponse contents entity contentType |<br>
> seasideResponse := aRequestContext response.<br>
> partialHeaders := seasideResponse headers.<br>
> cookies := seasideResponse cookies.<br>
> fullHeaders := ZnHeaders defaultResponseHeaders.<br>
> partialHeaders keysAndValuesDo: [ :key :value |<br>
> fullHeaders at: key put: value ].<br>
> cookies do: [ :each |<br>
> fullHeaders at: 'Set-Cookie' add: each oldNetscapeString.<br>
> fullHeaders at: 'Set-Cookie2' add: each rfc2965String ].<br>
> contentType := seasideResponse contentType greaseString.<br>
> contents := seasideResponse contents. "<------------------------ HERE - we are asking for contents"<br>
> entity := (ZnEntity bytes: contents) contentType: contentType; yourself.<br>
> ^ ZnResponse new<br>
> statusLine: (ZnStatusLine code: seasideResponse status);<br>
> headers: fullHeaders;<br>
> entity: entity;<br>
> yourself<br>
><br>
> It calls:<br>
><br>
> WABufferedResponse>>contents<br>
> ^ contentsStream contents "<------------------------ HERE - normally, asking underlying stream for contents"<br>
><br>
> An the error is coming here:<br>
><br>
> RWBinaryOrTextStream>>contents<br>
> "Answer with a copy of my collection from 1 to readLimit."<br>
><br>
> | newArray |<br>
> isBinary ifFalse: [^ super contents]. "String"<br>
> readLimit := readLimit max: position.<br>
> newArray := ByteArray new: readLimit. "<------------------------ HERE - we are creating array of bytes (SmallInteger 0 - 255)"<br>
> ^ newArray replaceFrom: 1<br>
> to: readLimit<br>
> with: collection "<------------------------ HERE - but we are having WideString in collection - characters"<br>
> startingAt: 1.<br>
><br>
> Now we are calling primitive 105:<br>
><br>
> ByteArray>>replaceFrom: start to: stop with: replacement startingAt: repStart<br>
> "Primitive. This destructively replaces elements from start to stop in the receiver starting at index, repStart, in the collection, replacement. Answer the receiver. Range checks are performed in the primitive only. Optional. See Object documentation whatIsAPrimitive."<br>
> <primitive: 105><br>
> super replaceFrom: start to: stop with: replacement startingAt: repStart "<------------------------ HERE - it fails and continues here"<br>
><br>
> It calls loop in SequenceableCollection:<br>
><br>
> ByteArray(SequenceableCollection)>>replaceFrom: start to: stop with: replacement startingAt: repStart<br>
> "This destructively replaces elements from start to stop in the receiver<br>
> starting at index, repStart, in the sequenceable collection,<br>
> replacementCollection. Answer the receiver. No range checks are<br>
> performed."<br>
><br>
> | index repOff |<br>
> repOff := repStart - start.<br>
> index := start - 1.<br>
> [(index := index + 1) <= stop]<br>
> whileTrue: [self at: index put: (replacement at: repOff + index)] "<------------------------ HERE - here we are putting character into ByteArray"<br>
><br>
> Stops here at Object at primitive 61:<br>
><br>
> ByteArray(Object)>>at: index put: value<br>
> "Primitive. Assumes receiver is indexable. Store the argument value in<br>
> the indexable element of the receiver indicated by index. Fail if the<br>
> index is not an Integer or is out of bounds. Or fail if the value is not of<br>
> the right type for this kind of collection. Answer the value that was<br>
> stored. Essential. See Object documentation whatIsAPrimitive."<br>
><br>
> <primitive: 61><br>
> index isInteger ifTrue:<br>
> [self class isVariable<br>
> ifTrue: [(index >= 1 and: [index <= self size])<br>
> ifTrue: [self errorImproperStore] "<------------------------ HERE - ends here"<br>
> ifFalse: [self errorSubscriptBounds: index]]<br>
> ifFalse: [self errorNotIndexable]].<br>
> index isNumber<br>
> ifTrue: [^self at: index asInteger put: value]<br>
> ifFalse: [self errorNonIntegerIndex]<br>
><br>
> I've seen this problem mostly with Seaside-REST, but also in some other posts from Seaside.<br>
><br>
> Any idea how to fix it?<br>
><br>
> Regards,<br>
> Tomas<br>
><br>
><br>
> On Wed, Jun 26, 2013 at 12:17 AM, Sven Van Caekenberghe <<a href="mailto:sven@stfx.eu">sven@stfx.eu</a>> wrote:<br>
> Hi Tomas,<br>
><br>
> Thanks for the report: this is an important area indeed.<br>
><br>
> However, the comment says it: this is intentional, and as far as I know, it is correct. You see, Zinc will correctly decode/encode any HTTP payload, using the supplied mime-type and/or charsets. Seaside is written such that it does not want this: it insists on doing this on its own. That is why ZnZincServerAdaptor is _not_ using the normal request reading code of Zn, but uses a special option to read everything binary. The stupid thing is that even though Seaside needs bytes, it wants them as a String. That is the reason for the otherwise brain dead #asString (and the implicit copy is inefficient as well).<br>
><br>
> Of course, you will see your special characters there if you do UTF8 decoding, but that is because you already know what is inside.<br>
><br>
> What normally happens, is that later on in the processing, Seaside will access the WARequest payload using proper decoding, using its own framework (much like what Zn would do). AFAIK this whole process works. You can actually test this using some of the functional tests.<br>
><br>
> I am not sure that Seaside-REST is doing the right thing (there were some issues with SmalltalkHub as well), but I would think so.<br>
><br>
> Are you sure you have set the correct encoding on the adaptor ?<br>
><br>
> Are you sure you are posting as application/json;charset=utf-8 and if you do not set the charset, are you sure utf-8 is the default ?<br>
><br>
> Are you sure your REST handler and/or JSON parser does the right thing ?<br>
><br>
> It is too late right now, but if we want to get further with this, I will need a failing unit test - if these exist in Seaside-REST, but I would assume so. I have no experience running Seaside-REST, I am using Zinc-REST myself, but I would like to learn.<br>
><br>
> Regards,<br>
><br>
> Sven<br>
><br>
> On 25 Jun 2013, at 23:24, Tomas Kukol <<a href="mailto:tomas.kukol@gmail.com">tomas.kukol@gmail.com</a>> wrote:<br>
><br>
> > Hi Sven.<br>
> ><br>
> > I've had a problem when POSTing non-ascii UTF-8 characters in JSON to Seaside REST service. I've located the problem in the method ZnZincServerAdaptor>>requestBodyFor: where the body of ZnRequest is translated to body of WARequest. I use Pharo 1.4 with Seaside 3.0.8 and Zinc-Seaside-SvenVanCaekenberghe.40.<br>
> ><br>
> > When the POSTed JSON contains non-ascii UTF-8 characters (Czech characters), they are corrupted. The problem is on the "MARKED" line, where the array of bytes changed to string by asString.<br>
> ><br>
> > "Problematic" code:<br>
> ><br>
> > ZnZincServerAdaptor>>requestBodyFor: aZincRequest<br>
> > ^ (aZincRequest method ~= #TRACE<br>
> > and: [ aZincRequest hasEntity<br>
> > and: [ aZincRequest entity isEmpty not<br>
> > and: [ (aZincRequest entity contentType matches: ZnMimeType applicationFormUrlEncoded) not<br>
> > and: [ (aZincRequest entity contentType matches: ZnMimeType multiPartFormData) not ] ] ] ])<br>
> > ifTrue: [<br>
> > "Seaside wants to do its own text conversions"<br>
> > aZincRequest entity bytes asString "MARKED" ]<br>
> > ifFalse: [<br>
> > String new ]<br>
> ><br>
> > I did a quick correction, which is not nice, but works for me:<br>
> ><br>
> > ZnZincServerAdaptor>>requestBodyFor: aZincRequest<br>
> > ^ (aZincRequest method ~= #TRACE<br>
> > and: [ aZincRequest hasEntity<br>
> > and: [ aZincRequest entity isEmpty not<br>
> > and: [ (aZincRequest entity contentType matches: ZnMimeType applicationFormUrlEncoded) not<br>
> > and: [ (aZincRequest entity contentType matches: ZnMimeType multiPartFormData) not ] ] ] ])<br>
> > ifTrue: [<br>
> > "Seaside wants to do its own text conversions"<br>
> > ZnUTF8Encoder new decodeBytes: aZincRequest entity bytes "CORRECTED" ]<br>
> > ifFalse: [<br>
> > String new ]<br>
> ><br>
> > My correction tries to decode byte array with ZnUTF8Encoder and the result is OK.<br>
> ><br>
> > Maybe I would recommend to use GRPharoUtf8Codec (although I like ZnUTF8Encoder more) or even better self codec (self = ZnZincServerAdaptor) to try to decode the bytes.<br>
> ><br>
> > Regards,<br>
> > Tomas Kukol<br>
> > _______________________________________________<br>
> > seaside mailing list<br>
> > <a href="mailto:seaside@lists.squeakfoundation.org">seaside@lists.squeakfoundation.org</a><br>
> > <a href="http://lists.squeakfoundation.org/cgi-bin/mailman/listinfo/seaside" target="_blank">http://lists.squeakfoundation.org/cgi-bin/mailman/listinfo/seaside</a><br>
><br>
><br>
><br>
> --<br>
> Sven Van Caekenberghe<br>
> <a href="http://stfx.eu" target="_blank">http://stfx.eu</a><br>
> Smalltalk is the Red Pill<br>
><br>
> _______________________________________________<br>
> seaside mailing list<br>
> <a href="mailto:seaside@lists.squeakfoundation.org">seaside@lists.squeakfoundation.org</a><br>
> <a href="http://lists.squeakfoundation.org/cgi-bin/mailman/listinfo/seaside" target="_blank">http://lists.squeakfoundation.org/cgi-bin/mailman/listinfo/seaside</a><br>
><br>
> _______________________________________________<br>
> seaside mailing list<br>
> <a href="mailto:seaside@lists.squeakfoundation.org">seaside@lists.squeakfoundation.org</a><br>
> <a href="http://lists.squeakfoundation.org/cgi-bin/mailman/listinfo/seaside" target="_blank">http://lists.squeakfoundation.org/cgi-bin/mailman/listinfo/seaside</a><br>
<br>
_______________________________________________<br>
seaside mailing list<br>
<a href="mailto:seaside@lists.squeakfoundation.org">seaside@lists.squeakfoundation.org</a><br>
<a href="http://lists.squeakfoundation.org/cgi-bin/mailman/listinfo/seaside" target="_blank">http://lists.squeakfoundation.org/cgi-bin/mailman/listinfo/seaside</a><br>
</div></div></blockquote></div><br></div>