[BUG] extraVMMemory handling is odd

John.Maloney at disney.com John.Maloney at disney.com
Fri Oct 8 18:05:16 UTC 1999


Good point, Tim. Thanks for pointing this out.


>The fairly recently added code to handle the extraVMMemory parameter is buggy
>in the sense that it is platform-irritant. So far as  can remember, the only
>platform that needs to reserve memory for the VM is the Mac, yet this code will
>reduce the heapSize for all platforms regardless of whether it makes sense or
>not. I don't think it likely that it would cause any big problems, but it might
>be better to ensure this by adding a macro that can by default _not_ reduce the
>heapSize and can be redefined in MacLand to do whatever.
>For example,
>#define adjustHeapSize( origHS, arg) origHS
>and
>#ifdef macintosh
>#undef adjustHeapSize
>#define adjustHeapSize( origHS, arg) origHS - arg
>etc
>and replace the line in Interpreter>readImageFromFile:HeapSize:StartingAt: to
>read
>	heapSize _ self cCode: 'adjustHeapSize( desiredHeapSize, extraVMMemory)'.
>
>tim





More information about the Squeak-dev mailing list