Request for enhancement

Dan Ingalls Dan.Ingalls at disney.com
Fri May 12 18:35:32 UTC 2000


Folks -

It occurred to me that it's silly for the browser to show both 'all' and 'as yet unclassified', and also silly to show both 'all' and 'no messages'.

I made the change shown below (which should do the job), and it had no effect.  The logic in this area of the browser has been worked on by a number of people, and it is pretty messy -- there are redundant implementations (see rawMessageCategoryList, for example), and when I put a printout in this method, I found it being called *4 times* when a new class is selected!

So this is a request for someone who knows their way around the browser to track down why the change below doesn't take effect, and why the method gets called four times, and submit a changeset that does the job right.  I would do it, but I'm jammed right now.

Please send out a message if you are interested, to avoid duplicated effort.

Thanks
	- Dan
----------------------
!Browser methodsFor: 'message category list' stamp: 'di 5/10/2000 16:18'!
messageCategoryList
	"Answer the selected category of messages."

	| cats |
	classListIndex = 0 ifTrue: [^ Array new].
	cats _ self classOrMetaClassOrganizer categories.
	cats = {ClassOrganizer nullCategory} ifTrue:
		["Dont bother to show 'all' category with 'no messages'."
		^ cats].
	cats = {ClassOrganizer default} ifTrue:
		["Dont bother to show 'as yet unclassified' with 'all' category."
		^ {ClassOrganizer allCategory}].
	^ {ClassOrganizer allCategory} , cats! !






More information about the Squeak-dev mailing list