[ALL Concerned]: supporting the addition of change and theharvesters
Doug Way
dway at riskmetrics.com
Thu Dec 13 01:00:22 UTC 2001
ducasse wrote:
>
> So write simple SUnit tests, so that harvesters have an easier job:
>
> ...
>
> Think that the guy that is trying to understand what you made would love to
> be sure that your code is not breaking something else (Doug I think that you
> have all the time this kind of question, isn't?), or at least he can
> understand your fix.
Yes, I agree that including unit tests with submissions could be encouraged. There was actually a submitted fix in the October batch (from Gerald Leeb) which included a unit test, and both the fix and its test were incorporated in the image.
Probably it shouldn't be a requirement that all submissions have tests, though. :-) For example, a game goodie which someone submits wouldn't need them as much, nor would a cosmetic change to the UI.
But with some kinds of submissions/fixes, it does make it much easier to determine what exactly was fixed. And even if only a very tiny portion of the Squeak image currently has tests, it may be good practice for the community to add more, and it builds up a larger base of example tests in the image for people to refer to.
- Doug Way (a harvester guy)
dway at riskmetrics.com
More information about the Squeak-dev
mailing list
|