[BUG][FIX] YellowButtonBit and BlueButtonBit are swapped

Bert Freudenberg bert at isg.cs.uni-magdeburg.de
Tue Mar 5 23:58:22 UTC 2002


On Tue, 5 Mar 2002, Lex Spoon wrote:

> 
> > > 	red  =>  main, primary
> > > 	yellow  =>  menu
> > > 	blue  =>  halo, gesture
> > 
> > I'd leave the colors in the code.
> 
> Why?  The code is getting just as mixed up as humans do.

Because any scheme will do. This one is at least well documented. You
might change all Swiki pages, but do you want Mark to retract this book?

Your main concern in the original mail was that people do mix up the
colors, with the reference to whoever implemented the bit masks in sq.h
and the win32 event handling code. But it's all fine, nothing was mixed
up: I spoke to the guy, today. Every serious Squeak developer knows what
red, yellow, and blue mean. 

Indeed, if everyone was using the *names* instead of hard-coded constants,
the problem wouldn't have happened. When you use the terms "primary",
"secondary" and so on, it's just too tempting to use the numbers 1 and 2 
instead of constants. *That* is the problem.

-- Bert





More information about the Squeak-dev mailing list