David T. Lewis wrote:

> Good, I justed posted a VM fix for this. Can you check to see if my
proposed fix messes up 
> your MOP project? If so, maybe my fix is not the best way to do it.

	No, not really. SqMOM is quite tolerant about this kind of mess
;-)

	Cheers,

	PhiHo.


-----Original Message-----
From: squeak-dev-admin at lists.squeakfoundation.org
[mailto:squeak-dev-admin at lists.squeakfoundation.org] On Behalf Of David
T. Lewis
Sent: Saturday, March 16, 2002 5:38 PM
To: squeak-dev at lists.squeakfoundation.org
Subject: Re: [ENH][GOODIE] OSProcess V3.0 (OSProcess for Windows)


On Sat, Mar 16, 2002 at 04:07:39PM -0500, PhiHo Hoang wrote:
> David T. Lewis wrote:
> 
> > It looks like ObjectMemory>>pushRemappableOop: is using a stack 
> > which
> has been allocated with > 25 elements, and it has no error checking to

> prevent stack overflows.
> 
> > p.s. Just comment out the call to primitiveGetEnvironmentStrings in
> > WindowsOSProcessAccessor>>primGetEnvironmentStrings if you want to
> > get OSProcess working. There will probably be some things that don't
> work right in
> > CommandShell if you do this, but at least your VM should stop 
> > crashing
> ;)
> 
> 	Instead, I pumped up the 'remapBuffer[26]' to 'remapBuffer[128]'
then 
> everything worked like a charm.
> 
> 	Maybe someone should revise the VM to ensure that there will be
no 
> overflows.

Good, I justed posted a VM fix for this. Can you check to see if my
proposed fix messes up your MOP project? If so, maybe my fix is not the
best way to do it.

Dave