KCP looking for external reviewers
ducasse at iam.unibe.ch
Fri Apr 4 18:15:08 UTC 2003
On Friday, April 4, 2003, at 06:50 PM, Daniel Vainsencher wrote:
> Cool. I want you to get reviewers, but "Kernel" sounds a little scary.
No it is not. In fact Morph is far more complex. This is just that this
is a bit meta.
> Actually many of the changes you're making are pretty simple design
> issues that don't require understanding any voodoo to review, but a few
> small things would help:
We did that on purpose. Basically there are a lot of basic oo modeling
Moving methods at the right place, having consistent interfaces.
Minimizing dependencies between classes.
> * I am not sure what problems you're actually attacking, from the list
> of suggestions. Unless you explain every goal you decide to attack, why
> should people look at your changesets? Here are the goals I know about
> - Eliminate dependencies from the kernel class on application classes.
Yes this is goal one.
Having a small kernel based on layers. So that we could use the kernel
without the layers.
> - Move user level functionality (for example, that supporting
> reflection (browsing senders)) out of the kernel.
Yes. But the browse menu use POPUPMENU so this was having dependency to
> Anything else? make it clear on the web page.
> * Since you're changing design, it would be nice to have justifications
> for the major decisions.
The only design point up until now was the creation of the class
All the rest is cleaning for example using self environment instead of
is just using a method that exist but everybody forgot.
> For example, is self environment always a good
> replacement for Smalltalk? external reviewers shouldn't need to reverse
> engineer your changes, just review them.
Hardcoding Smalltalk everywhere is simply bad because the method
existed before. This way a class can define its own environment.
Hardcoding everything hampered that.
> * Sometime the name is so brief,
This is because on mac we cannot have long name. I loaded a changeset
of diego that fixed that.
> I don't understand what the changeset
> is supposed to do. This prevents me from finding something nice and
> reviewing it.
But there is always a premable (or this was a mistake from us). We
editing the page because everything is in the preamble. So we were
going too slow.
Tell me if the information in the preamble is not enough.
> These should make it easier for
> Stephane Ducasse <ducasse at iam.unibe.ch> wrote:
>> Hi guys
>> We started slowly but we started. We need external reviewers for our
>> I would like to see them included in 3.6 because there are really
>> simple until now.
>> Currently we are focusing now on having the smallest core for Class,
>> Behaviour, ClassDescription, and Metaclasses.
>> The first design changes introduced is the introduction of a class
>> SystemNavigation that should contain all the navigation code
>> (browseAll...). Note that all the browse methods defined in the class
>> SystemDictionary should be move into this class too to avoid
>> code and logic.
>> Next Major Tasks:
>> - Look and clean the classBuilder
>> - Look and clean the systemOrganization
>> - Remove fileoutasHTML from the kernel
>> - Move fileout functionality out of the kernel in another layer
>> - Coherent and simple funnel for changes notification and access to
>> - Coherent and simple funnel for access to the compiler from the
>> classes (fixes classParser and classScanner as role always complained
>> about them been wrong)
>> Prof. Dr. Stéphane DUCASSE
>> "if you knew today was your last day on earth, what would you do
>> different? ... especially if,
>> by doing something different, today might not be your last day on
>> earth" Calvin&Hobbes
>> "The best way to predict the future is to invent it..." Alan Kay.
>> Open Source Smalltalks: http://www.squeak.org,
>> Free books for Universities at
>> Free Online Book at
Prof. Dr. Stéphane DUCASSE
"if you knew today was your last day on earth, what would you do
different? ... especially if,
by doing something different, today might not be your last day on
"The best way to predict the future is to invent it..." Alan Kay.
Open Source Smalltalks: http://www.squeak.org,
Free books for Universities at
Free Online Book at
More information about the Squeak-dev