KCP looking for external reviewers
bergel at iam.unibe.ch
Sat Apr 5 15:37:40 UTC 2003
If I try to get in an harvester's shoes I agree a lot of care have to be taken for the change explanation.
The actual way of documenting our changes is based upon:
- Change preamble
- Method comment (if necessary (i.e., when the method name is not obvious enought)), and the last but __not__ the least,
- Writing Tests
We take care to __always__ providing a test for __any_ test we are proposing.
The actual fact is a wiki page is not enought for managing such process, it takes a lot of time for just uploading the changes.
In my humble opinion, it seems difficult to spend more time than we are doing for explaining changes. I think such process need a confidence relationship.
I agree we have to discuss all together about major refactoring. But right now, our changes are only based on SmallInt results and on code duplication.
On Sat, Apr 05, 2003 at 04:24:17PM +0200, Stephane Ducasse wrote:
> >I caution you - this is an open project. To the extent that you close
> >your process by delaying other people's access to your design
> >directions, you risk them not being accepted.
> Just a point. The changeset are available explained. The wiki is the
> maximum we can do. If this is not enough tell us because may be
> cleaning the kernel only for us will be more efficient.
> Sorry I start to be pissed off by this discussion.
> >It's your call. I want a
> >clean kernel, but if I see iffy decisions implemented, I will have no
> >qualms about pushing to reject them.
> >Pushing out UI is clear. How about global analyses (like
> >unSentMessages)? seems to me that is another direction that can be
> >extended in arbitrary forms, and should be pushed out.
> >No problem if you disagree, but state the design decisions that drive
> >your implementation.
> Prof. Dr. Stéphane DUCASSE
> "if you knew today was your last day on earth, what would you do
> different? ... especially if,
> by doing something different, today might not be your last day on
> earth" Calvin&Hobbes
> "The best way to predict the future is to invent it..." Alan Kay.
> Open Source Smalltalks: http://www.squeak.org,
> Free books for Universities at
> Free Online Book at
Alexandre Bergel http://www.iam.unibe.ch/~bergel
More information about the Squeak-dev