I agree. I reviewed this refactoring and indeed we should push the  
cleaning of Squeak.

Stef


On Tuesday, April 29, 2003, at 10:17 AM, Marcus wrote:

> Hi!
>
> What is supposed to happen now? Will this be added to the  
> update-stream?
> If yes, why not yet? If no, why not? (THIS REFACTORING HAS EVEN  
> SUNIT-TESTS)
>
> We *really* need better turnaround times for small refactorings...
>
>     Marcus
>
>
> On Sun, Apr 13, 2003 at 02:32:13PM +0200, Stephane Ducasse wrote:
>>
>> On Tuesday, April 8, 2003, at 01:20 PM, Marcus Denker wrote:
>>
>>> Change Set:		instrPrinter
>>> Date:			8 April 2003
>>> Author:			Marcus Denker
>>>
>>> A refactoring for InstructionPrinter,
>>> AbstractInstructionPrinter and InstVarRefLocator:
>>>
>>> AbstractInstructionPrinter:
>>>
>>> moved the instVar and a method into InstVarRefLocator, now this class
>>> can
>>> be used as a Abstract Superclass for
>>> both InstructionPrinter and InstVarRefLocator
>>>
>>> Renamed to InstructionClient (c.f. VisualWorks).
>>>
>>> InstructionPrinter: refactored to be a
>>> subclass of InstructionClient"
>>>
>>> Tests are provided for the three changed classes, see attached files:
>>>
>>> InstructionClientTest.st.gz
>>> InstructionPrinterTest.st.gz
>>> InstVarRefLocatorTest.st.gz
>>>
>>> --   
>>> Marcus Denker marcus at ira.uka.de  -- Squeak! http://squeak.de
>>>
>>> <instrPrinter.6.cs.gz><InstVarRefLocatorTest.st.gz><InstructionClient 
>>> Te
>>> st.st.gz><InstructionPrinterTest.st.gz>
>>>
>> Prof. Dr. Stéphane DUCASSE
>> http://www.iam.unibe.ch/~ducasse/
>>  "if you knew today was your last day on earth, what would you do
>> different? ...  especially if,
>>  by doing something different, today might not be your last day on
>> earth" Calvin&Hobbes
>>
>> "The best way to predict the future is to invent it..." Alan Kay.
>>
>> Open Source Smalltalks: http://www.squeak.org,
>> http://www.gnu.org/software/smalltalk/smalltalk.html
>> Free books for Universities at
>> http://www.esug.org/sponsoring/promotionProgram.html
>> Free Online Book at
>> http://www.iam.unibe.ch/~ducasse/WebPages/FreeBooks.html
>>
>>
>
>
Prof. Dr. Stéphane DUCASSE
http://www.iam.unibe.ch/~ducasse/
  "if you knew today was your last day on earth, what would you do  
different? ...  especially if,
  by doing something different, today might not be your last day on  
earth" Calvin&Hobbes

"The best way to predict the future is to invent it..." Alan Kay.

Open Source Smalltalks: http://www.squeak.org,  
http://www.gnu.org/software/smalltalk/smalltalk.html
Free books for Universities at  
http://www.esug.org/sponsoring/promotionProgram.html
Free Online Book at  
http://www.iam.unibe.ch/~ducasse/WebPages/FreeBooks.html