[ENH][Refactoring] InstructionPrinter ([approved] dvf
danielv at netvision.net.il
Wed Apr 30 11:16:07 UTC 2003
I see. In the previous state, each of two classes held a meaningless
subset of the variable references...
Yuck. This changeset cleans up plenty of cruft.
Marcus <marcus at ira.uka.de> wrote:
> On Wed, Apr 30, 2003 at 12:00:13PM +0200, Daniel Vainsencher wrote:
> > I'm reviewing this now for approval.
> > I didn't understand the use of the new variable "bingo" which seems to
> > be initialized, returned, but never updated?
> > Can either of you explain it?
> This variable was pushed down from AbtractIntructionPrinter, together
> with the Method that returns it:
> interpretNextInstructionUsing: aScanner
> bingo _ false.
> aScanner interpretNextInstructionFor: self.
> So this simply interprets all bytecodes, sets bingo to "true"
> when seeing an IntVar reference, e.g.
> pushReceiverVariable: offset
> bingo _ true
> (this method in not in the changeset, it's allready there)
More information about the Squeak-dev