[ENH][Refactor] PLMCleanUpStart

Eddie Cottongim cottonsqueak at earthlink.net
Sat Aug 9 21:27:22 UTC 2003


Changeset looks good so far.

While we're looking at this area, here's a suggestion. Can we get rid of the
resizing of every morph to be 9999 wide? Other than being ugly, there could
be problems if we actually start using list items other than StringMorphs -
they may not appreciate being resized grossly. It will also make list
initializing a touch faster.

Attached is a first shot at doing so - its meant to go on top of Daniel's
changeset, not the in-image version, though it could be done there, too.

Eddie

----- Original Message -----
From: "Daniel Vainsencher" <danielv at netvision.net.il>
To: <squeak-dev at lists.squeakfoundation.org>
Sent: Saturday, August 09, 2003 10:28 AM
Subject: [ENH][Refactor] PLMCleanUpStart


> "Change Set: PLMCleanUpStart
> Date: 9 August 2003
> Author: Daniel Vainsencher
>
> This changeset adds comments for all PLM subclasses.
>
> Also removes the assumption of uniform height in PluggableListMorph (not
> yet in subclasses), and refactors the morph generation. Might slow list
> update down a bit.
>
> Factors out the StringMorph creation and initialization logic to
> simplify the methods and reduce duplication.
>
> The goal is to introduce the ability to accept items other than
> String/Text/MethodReference, and display them as morphs other than
> StringMorphs.
>
> Patches/advice about how to handle PLM variants welcome."!
>


----------------------------------------------------------------------------
----


-------------- next part --------------
A non-text attachment was scrubbed...
Name: PLMNoResizing.1.cs.gz
Type: application/octet-stream
Size: 901 bytes
Desc: not available
Url : http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20030809/4220174a/PLMNoResizing.1.cs.obj


More information about the Squeak-dev mailing list