[FIX] UrlPortNumberExtractFix-mu
ducasse
ducasse at iam.unibe.ch
Fri Dec 26 09:28:14 UTC 2003
Hi Masashi
> from preamble:
>
> "Change Set: UrlPortNumberExtractFix-mu
> Date: 24 December 2003
> Author: Masashi Umezawa
>
> HierarchicalUrl>>privateInitializeFromText: extracts a port number in
> URL, but it does not perform any error checking. It silently generates
> invalid URL instances. Now the method checks invalid port number in
> parsing.
>
> -Should pass:
> Url absoluteFromText: 'http://swikis.ddo.jp:8823/'
> -Should raise errors: (after the patch)
> Url absoluteFromText: 'http://swikis.ddo.jp:-1/'
> Url absoluteFromText: 'http://swikis.ddo.jp:65536/'
> Url absoluteFromText: 'http://swikis.ddo.jp:auau/'
Could you submit SUnit tests for that because you test your code
so make it possible for other to test it in one click.
This would be excellent. Because now, I will retest your code and write
the tests.
Else we will be at least three to run the same tests but in a not
repeatable fashion.
Stef
>
> "!
> <UrlPortNumberExtractFix-mu.cs.gz>
More information about the Squeak-dev
mailing list
|