Question about change set 5051u62, regarding #classComment:
Scott Wallace
scott.wallace at squeakland.org
Thu Jan 2 06:55:33 UTC 2003
Nevin,
Thank you for pointing this out.
The change in question was made in service of tracking down residual
users of a deprecated protocol during debugging, and was (obviously)
not made with reference to any non-Squeak usage.
A reasonable fix is indeed simply to revert the method, as suggested;
this remedy will will appear in a forthcoming update soon unless
objections are heard.
Sorry for the hassle, and cheers,
-- Scott
PS: apologies for the delay in replying.
At 3:39 PM -0700 12/22/02, Nevin Pratt wrote:
>In change set 5051u62, the implementation of
>ClassDescription>>classComment: was changed from:
>
> classComment: aString
> ^ self classComment: aString stamp: '<historical>'
>
>to
>
> classComment: aString
> aString isEmptyOrNil
> ifFalse: [self error: 'class comment set without stamp'].
> ^ self classComment: '' stamp: 'ignored'
>
>This change effectively breaks Squeak from being able to file in
>VisualWorks 3.0 chunk format fileins. I have found the
>interoperability for fileins between VW and Squeak to be very
>useful. In fact, my Squeak GLORP port just uses the VW GLORP filein
>directly. But, this change broke that ability.
>
>So, what was the rationale for making that change in Squeak? Is
>there any chance we can get it set back to what it was?
>
>Nevin
More information about the Squeak-dev
mailing list
|