[FIX][3.6a][ENH][KCP] TextStyleCleanup36-nk ([er][cd] somequestions and comments)

Daniel Vainsencher danielv at netvision.net.il
Fri Jul 4 01:49:33 UTC 2003


Hey Ned.

I'm reviewing only the first file, which is meant for the image.
I go over all the kinds of changes done, with comments where I had them.

- Paragraph asForm cleaned.
- StrikeFont>>actualFamilyNames encapsulates some otherwise repeated
code.
- Add font testing methods isRegular and isTTCFont. Maybe isRegular
could be called something more suggestive? should also be recategorized
under testing.
- why "reply ~~ nil" instead of notNil in
changeStyle/changeEmphasisOrAlignment?
- TWM>>helpMenu clashes slightly with KCP change to Imports entry.
- Methods are moved from Utilities to TextStyle. Why not use KCP style
deprecations on Utilities, for compatibility with applications that
still expects those services from Utilities?
- textAlignment, textAlignmentSymbol introduced in TextMorph,
TextMorphEditor. Why are the numbers returned in the two versions of
textAlignment not aligned? seems pretty confusing to me.

Also some methods are duplicated with current version.

Anyway, assuming that this code is converted to non-destructive
deprecation, I don't think there's a problem accepting these small
changes in beta, so that these small comments aren't very urgent.

Daniel



More information about the Squeak-dev mailing list