[BUG][FIX] ColorPickerMorph
Stephane Ducasse
ducasse at iam.unibe.ch
Sat Jul 19 18:50:07 UTC 2003
Hi andreas
I did not have the time to look at the code so I was just reacting to
the point of ned. With your fix (that I did not check) then my remark
does not make sense.
My point in general is that is that object should offer good and
default (if possible)
creational interface. As a client I do not have to guess that after new
I should send x and y in this order. If this is the case (you can find
easily a counter example),
it may be the case that a method newXY would be better for a client
point of view.
Stef
Going back latexing........
On Saturday, July 19, 2003, at 08:44 PM, Andreas Raab wrote:
>> This is the sign that the client interface creation of this class is
>> not really good then. Either it should provide a good interface or
>> it should break directly at creation time.
>
> I wonder what lets you come to that conclusion. ColorPickerMorph can
> stand
> on its own perfectly fine, except that there's a small bug when you
> delete
> it (fix attached).
>
> Cheers,
> - Andreas
> <FixColorPicker.1.cs>
More information about the Squeak-dev
mailing list
|