request for critique

Lex Spoon lex at cc.gatech.edu
Mon Jun 2 14:14:53 UTC 2003


Cool morph, David!

I would suggest adding some methods to convert from pixel coordinates to
image coordinates, instead of doing the computation inline all the time.
 

Also, you probably want to have a layoutChanged method that regenerates
the image.  Otherwise, how will you get a redraw if someone resizes the
morph?  (I haven't tested it, but it looks like it won't get redrawn.)

I love the comments and the general style of it!  That's some nice code.

Lex



More information about the Squeak-dev mailing list