Getting your stuff harvested (was [Q] version 3.5 - What is the
minimal consensus?)
Daniel Vainsencher
danielv at netvision.net.il
Thu Mar 6 11:26:00 UTC 2003
diegogomezdeck at consultar.com wrote:
> I think MCP and KCP have to be included as soon as possible. Faster we
> include them, faster we get bug reports, faster we fix them.
> Diego Gomez Deck
I want to start getting things in from the projects groups (and from
everyone else) asap. What can you do? for each of the proposed change
sets, give them as many as possible of the following QA tags -
- (sm) small. Changesets should be under 10k.
- (cd) changes documented (reasoning is given that explains every
different change made)
- (sl) SLint approved (you don't have to do what SLint says (sometimes
it's wrong), but have a good reason why you didn't)
- (er) - externally reviewed (design + code, by someone other than the
author, quite knowledgable with whatever is changed, and whatever else
it might affect)
- (et) externally tested, as er above, also using cd, but generally
making sure it doesn't break anything that uses it.
It would be a good idea to have those marking right there with your
changes. For the MCP/KCP, it should be on your page (see below). For
people submitting stuff on the list, the QA tags should be appended to the
subject, in parenthesis.
Something ready to become a changeset should look like this -
On a project page -
******************
# MCP-0001-initialize-dgd.cs.gz (sm,sl - dgd; cd - dgd+efc; et - gm; er
- ar)
* refactor of #initialize methods
* added/implemented #defaultBounds, #defaultBorderColor,
#defaultBorderWidth and #defaultColor
* some small methods categorization
* remove of most direct asignation for color, bounds, borderColor and
borderWidth variables
******************
On a CS submitted to the list -
[Fix] Morphs flip upside down when crossing the equator (sm - dgd)
If you just did an external review, simply reply with your comments
in the body, and in the subject, put your tag, as in
[Fix] Morphs flip upside down when crossing the equator (er - dvf)
Be careful not to change anything outside the parens, or your stuff
will probably be missed when things are grouped by subject.
If you do this, us harvesters really need to make only the kinds of
decision we should be making - "is there a reason not to put this in
right now? probably not. There it goes." I promise you that we'll do
that much faster than we can harvest things now.
Daniel
More information about the Squeak-dev
mailing list
|