[FIX] MethodReferenceHashFix-dgd ([er] ready to go)

Daniel Vainsencher danielv at netvision.net.il
Sat Mar 8 11:51:59 UTC 2003


diegogomezdeck at consultar.com wrote:
> 
> --Boundary_(ID_lQW/mjyUZyicq8ba1d9JRw)
> Content-type: text/plain; charset=iso-8859-1
> Content-transfer-encoding: 7BIT
> 
> New trial.
> 
> > A few comments I have -
> > 1. I think it's usually better to separate tests out more into separate
> > methods, using setUp to create the required common fixtures (commonly
> > used values, held in instance variables). That way it's more obvious
> > what is broken, and it's better documentation of the intention of the
> > test.
> 
> It's a subjective point.  The test I submitted has a "line of thinking"
> from 2 equals objects to 2 different ones.  In this case I prefer to show
> all the posibilities in 1 method.
> 
> Anyway I splited the test in 2 tests: #testEquals and #testNotEquals.
> 
> > 2. #hash is strangely formatted.
> 
> I use prettyprint. But the prettyprint option don't store the code after
> changing it but before. So you see the formatting but it's not stored.
> 
> Anyway I create another version of #hash.
> 
> > 3. It's probably better if people separate the Test changeset from the
> > fix changeset. This makes a few things easier -
> > * we can load the test before the fix, to see it break, and then load
> > the fix.
> > * they can easily be harvested separately (test now - fix after rework,
> > or test into test package - fix into update).
> 
> Done!
> 
> > Note that the fix works just fine, came with a test, and is simple -
> > it's generally very good, needs just a little polish. Most of the
> > reason it's rejected is that it's important to raise our awareness of
> > what makes work for the harvesters, so that future stuff is nearer
> > perfect.
> 
> Let's try now.
> 
> > Thanks, Diego.
> > Daniel
> 
> 
> Diego Gomez Deck
> 
> 
> 
> --Boundary_(ID_lQW/mjyUZyicq8ba1d9JRw)
> Content-type: application/x-gzip-compressed;
>  name=MethodReferenceHashTest-dgd.2.cs.gz
> Content-transfer-encoding: base64
> Content-disposition: attachment; filename=MethodReferenceHashTest-dgd.2.cs.gz
> 
> H4sIAAAAAAAAAM1VTW8aMRA9++D/MNDDJlIh4SMqQg0qhaa9JIcQ9RKhyuzOsqusbWJ7S1Plx3ds
> aEJgqRqlanuzZ8dvnt971kZnRkuY3JYobjrNLugUWnAuTJxB+/i4A9eFcGgdlIuEFn14ddJ6czwF
> raC32SYctFr9k26/3QYhoxqvjzKh5ggTdH3GztFlOrnEFA2qGD8Jm10RaiOZJ3zscRljm3h8WNIB
> 48vjHOcaPmqJ32GM8Q28DZVQ8Pt3I61sWbihacZaDjhfzYKtkX7cYHAKuYVcLgqUqBwmMCtddWdG
> FKlZRY7zRnWL1+XDbSkKO1SJvxJAkMplpIbN9NLSEgGN0QYOhEpgYfQMQzHNvx3yeo1zDzUSFsGW
> s7gQ1pLEFdM4y5V1gnafhcnFrMALIZGao4izcK6ivtC6GOexy7Wijw/dpPdcmzvaXVGDbbw3RBUN
> mcZrFaNBhpo9Iz8guiyVytU8AmIjF1QgC6Fz1DsKMaAMdHsE9CgNZ/cgtlBBKE0imO3yPWc7rV+2
> tQeFyyY1VkPsa68DZ26pITXofV1rab1NZUExIJsCXVq5JaLyJsk6ZxaLlDO2auvD9Q6/0z2XmTZ/
> 43AI2T6E8HW6wf2RtcEF3YMSTE6EOFkyfe0THIRNyAT40NHpUCE2GDttDncuXa/Q3aKb0LREmGS0
> iuXEGT9uNWVyJ2e6oKymWu9343kg/1xrqMEffgMX+j97Bn/f6lUQK6F8sJM8DRBuHVm0r+FJXKEx
> AKVBarMR1yduK/fcsNR/vomHkURjzeKXc1+Y85kwzZeRX0W0KqEGpf6KkzV7Grbze6rxH/JXhDDt
> BwAA
> 
> --Boundary_(ID_lQW/mjyUZyicq8ba1d9JRw)
> Content-type: application/x-gzip-compressed;
>  name=MethodReferenceHashFix-dgd.2.cs.gz
> Content-transfer-encoding: base64
> Content-disposition: attachment; filename=MethodReferenceHashFix-dgd.2.cs.gz
> 
> H4sIAAAAAAAAAKVTTW/aQBA9+7D/YUwOTg4hOAQFWQUVBdFySCuVHipFVFrsAW/j9bq7ayj99Z1d
> 0wYoKJV6sXbH783He7PRRCsJs+818udu+w7UEmJ45DrN4bbT6cJTwS0aC3WV0SGBi15835mDKqG/
> D+MW4jjp3SW3PeAyClnrIeflCmGGNgmCR7S5yj7hEjWWKb7nJp+IH9fZKmNjlzYIgv10bFQTXrvw
> WOBKwTsl8SeMMX2GNz7iA+7+9kGVpi7sSLdTJYeMNaXgqOJnmmE4HIAwIGRVoMTSYgaL2p5G5tQh
> gcvIMnb9QuFW0OSk0VkSoTX+I34AG2FzGH0YU1elscgzh51OjM8i1RpPE02FqUADl8JGBkplocQU
> DddbWGCqaoMuz8fFN0xf0FesFTLGwqOMIP3dTEhviEjDimthSNQIjOWyoiDZBN2b+xvvdNxN4j4Z
> PABOhXPUx/lY0BqVZoMaNjk6ANCHxklRrOnCy8wHuF7VTiL6U2k07uTCLDBcUvu+93aLBV/BYLGE
> 3yMPztbdIVgQUIkEnjwtLbgxs61cqALOMvdA8xP0qSECf4XegI7ojbSvld9HzUMI/8Oj/s4j9xTJ
> I7+Qf+zgMJO8KKa0+SvvjqI9WfOiRvcsNLqXTt6oA79ov8gTkZE/wm4bQy4PHPFPZSHsF9fcX6K7
> v1ekygHgQBeH8FMfD928gBkWtAmOerGrGLJfl5irZrUEAAA=
> 
> --Boundary_(ID_lQW/mjyUZyicq8ba1d9JRw)
> MIME-version: 1.0
> Content-type: text/plain; charset=us-ascii
> Content-transfer-encoding: 7BIT
> 
> 
> 
> --Boundary_(ID_lQW/mjyUZyicq8ba1d9JRw)--



More information about the Squeak-dev mailing list