[FIX] BoundsInHaloFix-nk

Scott Wallace scott.wallace at squeakland.org
Fri May 16 03:51:13 UTC 2003


Hi, Ned,

The #bounds: method for HaloMorph that your fileout removes was 
introduced by Dan Ingalls in update 4523HaloBoundsFix of 14 November 
2001.  Here's a quote from the preamble of that method:

It expands the bounds in the case that the halo is showing the target 
bounds rectangle, thus fixing a bug that left gribblies on the screen 
when dragging some morphs with this feature enabled...

While your 12 May fix does indeed allow the dismiss handle to be used 
in the halo when showBoundsInHalo is true, it's at the expense of 
allowing the gribblies to return.  To see them, for example, set 
showBoundsInHalo to true, draw a SketchMorph, rotate it, bring up a 
halo on the rotated Sketch, and drag it by the black handle.

Brian Keefer offered a fix in October 2002 for two of the 
showBoundsInHalo-related issues -- see 
http://groups.yahoo.com/group/squeak/message/50300 as well as earlier 
messages in that same thread.

There is certainly something very cheesy about the HaloMorph>>bounds: 
implementation introduced in update 4523, and it would be nice to get 
rid of it, but it should be done in such a way that the gribblies do 
not return.

Cheers,

   -- Scott


At 1:02 PM -0700 5/12/03, ned at bike-nomad.com wrote:
>from preamble:
>
>"Change Set:		BoundsInHaloFix-nk
>Date:			12 May 2003
>Author:			Ned Konz
>
>This fixes a long-standing bug where Morphs aren't deletable when the
>showBoundsInHalo Preference is enabled.
>
>12-May-2003	Initial change set creation.
>"!
>Content-type: application/octet-stream
>Content-disposition: attachment;filename="BoundsInHaloFix-nk.cs.gz"
>
>Attachment converted: titanium:BoundsInHaloFix-nk.cs.gz (????/----) (0004C723)
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20030515/48ff0fe6/attachment.htm


More information about the Squeak-dev mailing list