[TEST] FileDirectoryTests
Anthony Adachi
adachipro at yahoo.com
Wed May 21 17:09:59 UTC 2003
> Could you send your tests as changeset plus put
[TEST] (marcus is it
> correct?) so that marcus collect them?
Marcus Denker wrote:
> Yes, this is correct. But this needs to be a
gzip-compressed
> changeset, this is much easier to work with... just
cut'n
> pasting the content of the .cs file into the
mail-programm
> is not enough: This does not preserve
line-ending-encoding
> and garbles the code by nicely formating it...
undoing those
> changes is really too much work.
Stephen Pair wrote about his test:
> That's correct...this test passes on Unix and
Windows systems, but fails
> on Mac OSX (and apparently 9.1 as well). There is a
bug in the Mac
> implementation that should be corrected. That was
why I wrote the test
> and posted the message. The problem is that the Mac
implementation of
> the primitive FilePlugin>>primitiveDirectoryLookup
(dir_lookup() is the
> platform specific C function) is simply checking to
see whether there is
> an entry named like the FileDirectory without
regard to whether or not
> the entry is actually a directory. As I mentioned
earlier, I think the
> behavior on Windows and Unix is correct, and the
Mac implementation
> needs to be corrected to conform to the Windows and
Unix implementations.
>
> This test needs to be added to the
FileDirectoryTests so that we can
> make sure this issue doesn't manifest itself again
in the future.
Here's a change set containing the additions and
modifications I added to FileDirectoryTests along
with the test Stephen Pair submitted. I refactored
some of the test code so it is more isolated and gives
more accurate results. Some tests are broken and the
implementation needs to be fixed.
Note: The tests seem to be broken only under Mac OS
9.1 and Mac OS X .
Failing tests:
a. FileDirectory >>testExists -when checking if a
deleted directory exists.
b. FileDirectory >>
testDirectoryExistsWhenLikeNamedFileExists - as
explained above by Stephen.
c. FileDirectory >> testAttemptExistenceCheckWhenFile
- Files are not directories and the 'exists' method
should know that.
__________________________________
Do you Yahoo!?
The New Yahoo! Search - Faster. Easier. Bingo.
http://search.yahoo.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: FileDirectoryTests.1.cs.gz
Type: application/x-gzip
Size: 1679 bytes
Desc: FileDirectoryTests.1.cs.gz
Url : http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20030521/8da7eb06/FileDirectoryTests.1.cs.bin
More information about the Squeak-dev
mailing list
|