[UPDATES] MCP changes

Doug Way dway at riskmetrics.com
Fri May 23 04:17:49 UTC 2003


This hefty update includes all of the MCP (Morphic Cleanup Project) 
changes so far.  Diego has already checked for conflicts with the 
recent KCP changes, and separated the Test-related changes.

Thanks to the MCP and KCP teams for their great work!  From here on we 
can harvest all sorts of other enhancements and fixes.  (Of course, any 
Morphic-related enhancements/fixes will need to be checked for 
conflicts with these MCP changes, since there are a lot of them.)

- Doug Way


-------------------------------------------

5240MCP-Complete -- Diego Gomez Deck, German Morales, Javier Musa, Jose 
Laiolo, Andres Otaduy and Ned Konz -- 22 May 2003
This is the first set of changes produced by MCP-Project.
To see details about the project and its future look at 
http://minnow.cc.gatech.edu/squeak/3005
This 'official' acceptance for our work gives us a stop-and-go 
opportunity to define the next goals.
List of changes (probably incomplete):
- refactor of #initialize procedure, added/implemented #defaultBounds, 
#defaultBorderColor, #defaultBorderWidth and #defaultColor
- methods categorization
- remove of most direct assignation for color, bounds, borderColor and 
borderWidth variables
- replaces all isKindOf: Morph by isMorph
- deletion of #initialColor where corresponds
- remove of methods with the same behaviour in superclass
- remove of methods with only a super invocation
- added Morph>>hasExtension
- added Morph>>privateExtension:
- refactor the former users of the extension variable in Morph hierarchy
- added MorphExtension>>hasOtherProperties
- added MorphExtension>>privateOtherProperties:
- refactor the former users of the otherProperties variable in 
MorphExtension
- isSystemWindow added to Object and SystemWindow
- replaces all isKindOf: SystemWindow by isSystemWindow
- bug fixed in SoundLoopMorph>>defaultBounds
- TetrisBoard>>defaultColor now use an equivalent named color
- Remove of assignments at end of ifTrue:ifFalse: blocks
- Remove same code on ifTrue:ifFalse: blocks
- comparation with nil per #isNil/#notNil
- comparation with #size per #isEmpty/#notEmpty
- at:1 per first
- ~~ nil changed to #notNil
- at:2 changed to #second, at:3 to #third, etc
- remove unused #yourself.
- remove unused #=
- remove 2 methods equivalent to the superclass one moves 
isMorphicModel from Morph up to Object
- replaces almost every isKindOf: WhateverClass by isWhateverClass
- Assignment to same variable and end of ifTrue:ifFalse: blocks only 
when convenient .
- Replaces uses of ifTrue:/ifFalse: instead of min:/max:.
- HandMorph needsToBeDrawn: need to check for visible submorphs, not 
just for submorphs.
- SelectionMorph doDup:fromHalo:handle: doesn't duplicate morphs 
properly.
- refactor of same statements at end of #ifTrue:ifFalse blocks



More information about the Squeak-dev mailing list