[BUG][FIX] DeclarativePools

Stephane Ducasse ducasse at iam.unibe.ch
Sat May 31 08:42:07 UTC 2003


Hi tim

Great. I did not have the time to look at it but I trust your  
initiative.
On Friday, May 30, 2003, at 11:23 PM, Tim Rowledge wrote:

> A few weeks ago we had a useful discussion about the problems of  
> handling pool dictionaries and concluded that it might be useful to  
> use classes to do the job. Andreas duly produced a prototype for us  
> and included a really neat cleanup of scope handling.
>
> I've been checking out the code and it seems a nice step towards a  
> solution - we should adopt it. I now have a revised version that:-
> a) is fudged to make sure that all the pools are installed in the  
> image. This is a simplistic approach pro-tem until we solve the  
> problem of dependency in SM1.1 - the classes are small and at least it  
> would mean we can rely on pools being there for now.
> b) adds some changes to keep the 'explain' utilities working.
> c) simply prevents filing out of the new kind of pools dicts; we need  
> to work out what to do here. We could of course file out the class of  
> the pool dict but I think that is probably not correct.

> d) fix Smalltalk>poolUsers to handle the new pool classes.
I think that for once this is functionality that will stay in  
SystemDictionary :)


> There are some methods that need discussion here:-
>
> ReadWriteStream & GZipSurrogateStream>fileOutClass:andObject: &  
> ReadWriteStream >fileOutClass:andObject:blocking:,  
> SmartRefStream>appendClassDefns,  
> SystemOrganizer>fileOutCategory:on:initializing:,  
> Class>fileOutAsHtml:, Class>fileoutSharedPoolsOn:
> - all may need simplifying to drop the pool fileout.

I really have a problem with the idea of having Class>>fileOutAsHtml:
I think that the fileOut should be rethink: may be we should have a  
fileOuter, HTMLFileOuter...
This code is also really ugly, I had really hard time to create a new  
fileOuter that was compatible with
VW and there is all kinds of bad dirty logic full of if HTML.

Finally I was really wondering was a class such as SmartRefStream has  
reference to PopUpMenu......
but this another discussion.

If somebody has ideas to propose a cleaner solution please talk.
As a first step could we agree to get rid of the fileout as html  
feature?

Stef


>
> Class removeSharedPool: won't work - is it useful anymore? Not sent  
> and changing pools for a class is done by redfining class and using  
> #sharing:
>
> The file is  
> http://sumeru.stanford.edu/tim/pooters/SqFiles/deltas/ 
> DeclarativePools-4.sar
>
> tim
> -- 
> tim at sumeru.stanford.edu
>
>



More information about the Squeak-dev mailing list