Hi Doug,

> Yes, this seems to work as long as I don't have any browser windows 
> open. :-)  Actually, maybe a do-it should be added to the 
> preamble which 
> closes all open browser windows, because this will probably 
> bite a lot 
> of people.  (We could even have an inform: window which warns 
> about this 
> ahead of time.)

That is a good idea. I modfified my changeset accordingly and attached
it to this email.

> As to whether this "fix" should go in 3.7beta or wait until 3.8alpha, 
> that's hard to say.  Possibly it could go in 3.7beta if we 
> made it close 
> browser windows, etc.  It seems like a big enough change that 
> we might 
> want to wait until 3.8alpha though, if it's not too urgent.  
> On the plus 
> side, Dan has been talking about an accelerated schedule for 3.8 
> (June/July for 3.8final), so if it were to wait for 3.8, you wouldn't 
> have to wait *too* long.

I'm torn as well. On one hand, it would be good to have it in 3.7beta
because it fixes some bugs in the SystemChangeNotification framework and
with the drag'n'drop. However, these are all minor things and most
programmers will never run into them. 

Also, this changeset is quite big and so there is definitely a potential
that it breaks some other things. (Well, I have tested it quite
extensively, but I can't give a guarantee). Therefore, I can totally
understand that it is too big of a risk to introduce it so late in the
beta cycle.

For me, the most important thing is that this changeset gets
incoprorated before the code gets "out of date" (i.e., there is new code
modifying the same methods that are part of this changeset). But since
this changeset mainly affects kernel methods, it should be fine if we
wait until 3.8alpha.

Nathanael



> -----Original Message-----
> From: squeak-dev-bounces at lists.squeakfoundation.org 
> [mailto:squeak-dev-bounces at lists.squeakfoundation.org] On 
> Behalf Of Doug Way
> Sent: Mittwoch, 7. April 2004 22:11
> To: The general-purpose Squeak developers list
> Subject: Re: [KCP][FIX] KCP-0220-ClassOrganizerFixAndCleanup.8.cs
> 
> 
> Nathanael Schärli wrote:
> 
> >>Oops, I just noticed that I made a mistake when I manually
> >>edited the changeset (I accidentally used data from an older 
> >>changeset).
> >>    
> >>
> >
> >Ok. Here is the right version of the changeset.
> >
> >Cheers,
> >Nathanael
> >
> >PS: Don't forget to close the close all the browsers before 
> filing it 
> >in.
> >
> 
> Yes, this seems to work as long as I don't have any browser windows 
> open. :-)  Actually, maybe a do-it should be added to the 
> preamble which 
> closes all open browser windows, because this will probably 
> bite a lot 
> of people.  (We could even have an inform: window which warns 
> about this 
> ahead of time.)
> 
> As to whether this "fix" should go in 3.7beta or wait until 3.8alpha, 
> that's hard to say.  Possibly it could go in 3.7beta if we 
> made it close 
> browser windows, etc.  It seems like a big enough change that 
> we might 
> want to wait until 3.8alpha though, if it's not too urgent.  
> On the plus 
> side, Dan has been talking about an accelerated schedule for 3.8 
> (June/July for 3.8final), so if it were to wait for 3.8, you wouldn't 
> have to wait *too* long.
> 
> - Doug
> 
> 
> >  
> >
> >>-----Original Message-----
> >>From: squeak-dev-bounces at lists.squeakfoundation.org
> >>[mailto:squeak-dev-bounces at lists.squeakfoundation.org] On 
> >>Behalf Of Nathanael Schärli
> >>Sent: Mittwoch, 7. April 2004 15:56
> >>To: 'The general-purpose Squeak developers list'
> >>Subject: RE: [KCP][FIX] KCP-0220-ClassOrganizerFixAndCleanup.8.cs
> >>
> >>
> >>Oops, I just noticed that I made a mistake when I manually
> >>edited the changeset (I accidentally used data from an older 
> >>changeset).
> >>
> >>I will send an email with the right version as soon as I'm
> >>done with it...
> >>
> >>Nathanael
> >>
> >>    
> >>
> >>>-----Original Message-----
> >>>From: squeak-dev-bounces at lists.squeakfoundation.org
> >>>[mailto:squeak-dev-bounces at lists.squeakfoundation.org] On
> >>>Behalf Of Nathanael Schärli
> >>>Sent: Mittwoch, 7. April 2004 15:45
> >>>To: 'The general-purpose Squeak developers list'
> >>>Subject: [KCP][FIX] KCP-0220-ClassOrganizerFixAndCleanup.8.cs
> >>>
> >>>
> >>>Hi Doug and all
> >>>
> >>>Here is a changeset that fixes some missing triggers for the 
> >>>SystemChangeNotification framework by cleaning up the 
> >>>ClassOrganization hierarchy. It also fixes some other issues (see 
> >>>below). Note that the changeset is manually edited in 
> order to make 
> >>>it file in correctly.
> >>>
> >>>Nathanael
> >>>
> >>>
> >>>"Change Set:		KCP-0220-ClassOrganizerFixAndCleanup
> >>>Date:			6 April 2004
> >>>Author:			Nathanael Schaerli
> >>>
> >>>This changeset cleans up the ClassOrganizer hierarchy and 
> fixes some 
> >>>bugs in the SystemNotification framework. Furthermore, it 
> fixes some 
> >>>other bugs that got appearent while I was working on this 
> cleanup. In
> >>>detail:
> >>>
> >>>- Cleans up the ClassOrganizer hierarchy. This was 
> necessary because 
> >>>the old hierarchy was conceptually wrong and made it therefore 
> >>>unnecessarily hard to extend it.
> >>>- Makes sure that changes to the class organizer always
> >>>trigger the corresponding system change notifier event. (This 
> >>>was not the case so far).
> >>>- All the system change notification triggers are in the 
> >>>kernel where they actually happen. In particular, I removed 
> >>>all the triggers in the class Browser.
> >>>- Removes a few minor problems with nil values in the 
> >>>SystemChangeNotification framework.
> >>>- Removes a bug when using drag and drop between classes 
> >>>without having message categories selected.
> >>>
> >>>IMPORTANT:
> >>>- This changeset has been modified by hand in order to make
> >>>it file in properly.
> >>>- Close all the browser windows before filing this changeset in."
> >>>
> >>>
> >>>      
> >>>
> >>------------------------------------------------------------
> ----------
> >>--
> >>
> >>This body part will be downloaded on demand.
> >>
> 
> 
> 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: KCP-0220-ClassOrganizerFixAndCleanup.11.cs
Type: application/octet-stream
Size: 44575 bytes
Desc: not available
Url : http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20040408/f64e0943/KCP-0220-ClassOrganizerFixAndCleanup.11.obj